From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH v3 1/4] edac: Add an function to retrieve the EDAC debugfs node Date: Thu, 13 Aug 2015 10:52:01 +0200 Message-ID: <20150813085201.GC20004@nazgul.tnic> References: <1439326077-25507-1-git-send-email-lho@apm.com> <1439326077-25507-2-git-send-email-lho@apm.com> <20150812101219.GC14011@nazgul.tnic> <20150812104954.GD14011@nazgul.tnic> <20150813081537.GB20004@nazgul.tnic> <20150813104150.2c084a8c@ipc1.ka-ro> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20150813104150.2c084a8c-VjFSrY7JcPWvSplVBqRQBQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lothar =?utf-8?Q?Wa=C3=9Fmann?= Cc: Loc Ho , Mark Rutland , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Arnd Bergmann , Ian Campbell , Jon Masters , Mauro Carvalho Chehab , "patches-qTEPVZfXA3Y@public.gmane.org" , Rob Herring , Doug Thompson , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , linux-edac-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Thu, Aug 13, 2015 at 10:41:50AM +0200, Lothar Wa=C3=9Fmann wrote: > What's the point in having an accessor function that returns a driver > internal variable when this variable is exported anyway? Not driver-internal but EDAC-core internal. > This will only further inconsistencies because half of the users will > use the variable directly and the other half will use the accessor > function. The idea is that it is not visible outside of EDAC. The EDAC drivers themselves should see it. And yes, I admit that the accessors are maybe redundant then since EDAC drivers can use edac_debugfs ptr directly. Hmm, and that's ok too because my other concern about future refactorin= g is taken care of too because as long as all users of edac_debugfs are confined to drivers/edac/, changing stuff there is easy. Ok, I'm convinced, Loc, feel free to drop the accessors in your next version. Thanks. --=20 Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html