Re: [PATCH RESEND v6 0/2] Driver for TI tlc591xx 8/16 Channel i2c LED driver

[Andrew Lunn <andrew@lunn.ch>]

> > Hi Tomi
> > 
> > Our discussions were going around in circles, no progress being made.
> > The subsystem maintainer is ultimately the one who needs to decide,
> > bar Linus himself. Bryan Wu has seen all the discussions, and
> > ultimately decided the driver was O.K, despite any unresolved issues
> > you might have.
> 
> If so, Bryan did not comment to the unanswered questions in any way.
> More probable is that he missed them.

I would not jump to that conclusion. As one of the maintainers of
Marvell SoCs, i don't feel the need to address every open question
going back and forward between two developers, when i decide to end
the discussion by just accepting the patch.

> > If you think your PWM code is so much better, please submit a revert
> > patch plus your PWM LED driver. We can find somebody to do a side by
> > side review.
> 
> It's not about the driver code. That can be cleaned up if needed. The
> question is whether the driver should be a PWM driver or a LED driver.

There i disagree. It is all about the code. Release early, release
often.  Show us the code. Get it discussed, reviewed, tested, and then
ultimately merged.

You keep saying PWM is the way to solve this problem, but where is
your code showing your solution is superior to mine, yet still solves
my use case?

So please stop talking and show us the code.

   Thanks
	Andrew