From: Andrew Lunn <andrew@lunn.ch>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: cooloney@gmail.com, rpurdie@rpsys.net,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
Matthew.Fatheree@belkin.com, "R, Vignesh" <vigneshr@ti.com>
Subject: Re: [PATCH RESEND v6 0/2] Driver for TI tlc591xx 8/16 Channel i2c LED driver
Date: Mon, 17 Aug 2015 18:48:22 +0200 [thread overview]
Message-ID: <20150817164822.GA29494@lunn.ch> (raw)
In-Reply-To: <55D20E96.3020504@ti.com>
> TLC591xx is quite simple HW, and the code doing the HW programming
> should be identical for a pwm and for a led driver. I don't see either a
> pwm or a led driver being somehow superior. They are very similar simple
> drivers, implementing a different interface. Whether the interface works
> for you should be clear from the interface itself. The code is just details.
>
> On the other hand, if you want something you can use to test, it's a
> different case, but you haven't indicated any interest in that.
What i want is code in the kernel to driver the LEDs on my Linksys
WRT1900ac. You say, "the code is just details", is just plain
wrong. Code is the Linux kernel and is the process of getting stuff
into the kernel. I've followed the process, submitted code for review,
fixed up comments, got it tested and ACKed by people, and merged.
Where as all you have done is emailed.
So i'm done.
Andrew
next prev parent reply other threads:[~2015-08-17 16:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 22:08 [PATCH RESEND v6 0/2] Driver for TI tlc591xx 8/16 Channel i2c LED driver Andrew Lunn
2015-03-17 22:08 ` [PATCH RESEND v6 1/2] leds: tlc591xx: Document binding for the TI " Andrew Lunn
2015-04-20 13:09 ` Jacek Anaszewski
2015-04-20 17:46 ` Bryan Wu
2015-03-17 22:08 ` [PATCH RESEND v6 2/2] leds: tlc591xx: Driver " Andrew Lunn
2015-04-20 9:06 ` Jacek Anaszewski
2015-04-20 11:59 ` Andrew Lunn
2015-04-20 13:07 ` Jacek Anaszewski
[not found] ` <5534FA13.9090502-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-04-20 17:49 ` Bryan Wu
2015-03-29 19:28 ` [PATCH RESEND v6 0/2] Driver for TI tlc591xx " Andrew Lunn
2015-03-30 22:10 ` Bryan Wu
2015-08-17 12:11 ` Tomi Valkeinen
2015-08-17 13:27 ` Andrew Lunn
2015-08-17 14:11 ` Tomi Valkeinen
2015-08-17 14:21 ` Andrew Lunn
2015-08-17 16:40 ` Tomi Valkeinen
2015-08-17 16:48 ` Andrew Lunn [this message]
2015-08-17 17:08 ` Bryan Wu
2015-08-17 20:47 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150817164822.GA29494@lunn.ch \
--to=andrew@lunn.ch \
--cc=Matthew.Fatheree@belkin.com \
--cc=cooloney@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=tomi.valkeinen@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).