From: Vinod Koul <vinod.koul@intel.com>
To: Rameshwar Prasad Sahu <rsahu@apm.com>
Cc: dan.j.williams@intel.com, herbert@gondor.apana.org.au,
davem@davemloft.net, linux-crypto@vger.kernel.org,
dmaengine@vger.kernel.org, arnd@arndb.de,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, jcm@redhat.com,
patches@apm.com
Subject: Re: [PATCH v1 3/4] Crypto: Add support for APM X-Gene SoC CRC32C h/w accelerator driver
Date: Thu, 20 Aug 2015 11:18:28 +0530 [thread overview]
Message-ID: <20150820054828.GY13546@localhost> (raw)
In-Reply-To: <1438258268-3099-4-git-send-email-rsahu@apm.com>
On Thu, Jul 30, 2015 at 05:41:07PM +0530, Rameshwar Prasad Sahu wrote:
> + nents = sg_nents(req->src);
> + sg_count = dma_map_sg(dev, req->src, nents, DMA_TO_DEVICE);
> + if (!sg_count) {
> + dev_err(dev, "Failed to map src sg");
> + return -ENOMEM;
mapping error shouldn't be no mem error
> + }
> +
> + if (sg_count > XGENE_DMA_MAX_FLYBY_SRC_CNT) {
> + dev_err(dev, "Unsupported src sg len\n");
would be worth printing length
> + goto err;
> + }
> +
> + flags = DMA_CTRL_ACK;
why ACK?
> +
> + tx = dchan->device->device_prep_dma_crc32c(dchan, req->src,
> + req->nbytes,
> + reqctx->seed,
> + req->result,
> + flags);
We should add helper for this
--
~Vinod
next prev parent reply other threads:[~2015-08-20 5:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 12:11 [PATCH v1 0/4] Crypto: tcrypt: Add test case for APM X-Gene SoC CRC32C algo Rameshwar Prasad Sahu
2015-07-30 12:11 ` [PATCH v1 1/4] dmaengine: Add support for new feature CRC32C Rameshwar Prasad Sahu
2015-08-20 5:26 ` Vinod Koul
2015-08-20 6:29 ` Rameshwar Sahu
2015-08-20 7:08 ` Vinod Koul
2015-08-20 7:48 ` Rameshwar Sahu
2015-07-30 12:11 ` [PATCH v1 2/4] dmaengine: xgene-dma: Add support for CRC32C calculation via DMA engine Rameshwar Prasad Sahu
2015-08-20 5:40 ` Vinod Koul
2015-08-20 6:53 ` Rameshwar Sahu
2015-08-20 7:09 ` Vinod Koul
2015-07-30 12:11 ` [PATCH v1 3/4] Crypto: Add support for APM X-Gene SoC CRC32C h/w accelerator driver Rameshwar Prasad Sahu
2015-07-31 7:13 ` Herbert Xu
[not found] ` <20150731071358.GA25228-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2015-07-31 9:12 ` Rameshwar Sahu
2015-08-20 5:48 ` Vinod Koul [this message]
2015-08-20 7:01 ` Rameshwar Sahu
2015-08-20 7:10 ` Vinod Koul
2015-07-30 12:11 ` [PATCH v1 4/4] Crypto: tcrypt: Add test case for APM X-Gene SoC CRC32C algo Rameshwar Prasad Sahu
2015-07-30 12:20 ` [PATCH v1 0/4] " Rameshwar Sahu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150820054828.GY13546@localhost \
--to=vinod.koul@intel.com \
--cc=arnd@arndb.de \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=jcm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@apm.com \
--cc=rsahu@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).