From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Subject: Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver Date: Thu, 20 Aug 2015 11:01:58 +0200 Message-ID: <201508201101.58702.marex@denx.de> References: <1440053705-3836-1-git-send-email-vndao@altera.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Viet Nga Dao Cc: "linux-mtd@lists.infradead.org" , Brian Norris , David Woodhouse , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , nga_chi86 List-Id: devicetree@vger.kernel.org On Thursday, August 20, 2015 at 10:17:57 AM, Viet Nga Dao wrote: > Sorry for missing to reply the last question Hi! > >>> diff --git a/drivers/mtd/spi-nor/spi-nor.c > >>> b/drivers/mtd/spi-nor/spi-nor.c index 14a5d23..2ab7279 100644 > >>> --- a/drivers/mtd/spi-nor/spi-nor.c > >>> +++ b/drivers/mtd/spi-nor/spi-nor.c > >>> @@ -687,6 +687,24 @@ static const struct spi_device_id spi_nor_ids[] = > >>> { > >>> > >>> { "cat25c09", CAT25_INFO( 128, 8, 32, 2, SPI_NOR_NO_ERASE | > >>> > >>> SPI_NOR_NO_FR) }, { "cat25c17", CAT25_INFO( 256, 8, 32, 2, > >>> SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) }, { "cat25128", CAT25_INFO(2048, 8, > >>> 64, 2, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) }, + > >>> + /* Altera EPCQ/EPCS Flashes are non-JEDEC */ > >> > >> Are they really ? Last time I checked on CV SoC, I was able to read > >> their JEDEC ID just fine ; though it's true I used that EPCS core. > > Altera EPCS flash is non-jedec device. And this new controller is not > EPCS controller. If you look at the documentation i sent in another > email, they are not the same. https://www.altera.com/content/dam/altera- www/global/en_US/pdfs/literature/hb/cfg/cfg_cf52012.pdf page 15 ; seems like opcode 0x9f is supported. All the other opcodes seems compatible too. What is the problem ? Best regards, Marek Vasut