Re: [PATCH 2/3] ARM: dts: sun6i: Turn on gmac on Colombus

[Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1288 bytes --]

On Thu, Aug 20, 2015 at 08:23:27AM +0200, Hans de Goede wrote:
> Hi,
> 
> On 08/19/2015 05:17 PM, Maxime Ripard wrote:
> >On Fri, Aug 07, 2015 at 05:22:34PM +0200, Hans de Goede wrote:
> >>We've everything we need to support the gmac on Colombus, turn it on.
> >>
> >>Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> >
> >I recall that the phy was powered by one of the AXP221 regulators,
> >does it require some additional stuff (like a recent u-boot), or does
> >it just work and my memory is bad :) ?
> 
> I think it just works, it MAY be connected to aldo1 but according to
> the git history for the u-boot defconfig that one is used for wifi not
> for the gmac, and we do not enable any other "spare" regulators in the
> u-boot config.
> 
> I do not have any schematics, so no way to say for sure.
> 
> I can confirm that the GMAC work fine with the latest u-boot
> master. Looking in the history we've always enabled ALDO1
> on the Colombus in upstream u-boot, so this should all just work.

Except that if it is the case, the DT was working fine with the stock
bootloader, and it doesn't anymore, while we have no way to upgrade
it.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com