From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Norris Subject: Re: [PATCH v2 1/3] ARM: dts: rockchip: add veyron-jaq board Date: Mon, 24 Aug 2015 10:53:15 -0700 Message-ID: <20150824175315.GA81574@google.com> References: <1440022721-73712-1-git-send-email-briannorris@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Javier Martinez Canillas Cc: Heiko Stuebner , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Alexandru M Stan , Douglas Anderson , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On Thu, Aug 20, 2015 at 01:29:40AM +0200, Javier Martinez Canillas wrote: > Hello Brian, > > [...] > > > + > > +&rk808 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pmic_int_l &dvs_1 &dvs_2>; > > + dvs-gpios = <&gpio7 12 GPIO_ACTIVE_HIGH>, > > + <&gpio7 15 GPIO_ACTIVE_HIGH>; > > I see the dvs-gpios DT property is documented in the downstream > ChromiumOS 3.18 tree [0] but I don't see it neither mentioned in > Documentation/devicetree/bindings/mfd/rk808.txt in mainline nor code > that parses it in the drivers/regulator/rk808-regulator.c driver. Good catch. > So I think this should be removed and also the dvs_{1,2} pinctrl > lines. OK, will do. I see that jerry, minnie, and speedy also have the pinctrl lines. Should they be killed as well? > The rest of the patch looks good to me though so with these > removed feel free to add: > > Reviewed-by: Javier Martinez Canillas Thanks. > [0]: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-3.14/Documentation/devicetree/bindings/mfd/rk808.txt Brian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html