From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 1/7] dmaengine: st_fdma: Add STMicroelectronics FDMA DT binding documentation Date: Wed, 26 Aug 2015 08:12:36 +0100 Message-ID: <20150826071236.GS19409@x1> References: <1436371888-27863-1-git-send-email-peter.griffin@linaro.org> <1436371888-27863-2-git-send-email-peter.griffin@linaro.org> <20150819150605.GA13546@localhost> <20150825170840.GA1498@griffinp-ThinkPad-X1-Carbon-2nd> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20150825170840.GA1498@griffinp-ThinkPad-X1-Carbon-2nd> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Peter Griffin Cc: Vinod Koul , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, srinivas.kandagatla-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, maxime.coquelin-qxv4g6HH51o@public.gmane.org, patrice.chotard-qxv4g6HH51o@public.gmane.org, dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ludovic.barre-qxv4g6HH51o@public.gmane.org List-Id: devicetree@vger.kernel.org On Tue, 25 Aug 2015, Peter Griffin wrote: > Hi Vinod, >=20 > Thanks for reviewing. >=20 > On Wed, 19 Aug 2015, Vinod Koul wrote: >=20 > > On Wed, Jul 08, 2015 at 05:11:22PM +0100, Peter Griffin wrote: > > > This patch adds the DT binding documentation for the FDMA constro= ller > > > found on STi based chipsets from STMicroelectronics. > > >=20 > > > Signed-off-by: Ludovic Barre > > > Signed-off-by: Peter Griffin > > > --- > > > Documentation/devicetree/bindings/dma/st_fdma.txt | 76 +++++++++= ++++++++++++++ > > > 1 file changed, 76 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/dma/st_fdma= =2Etxt > > >=20 > > > diff --git a/Documentation/devicetree/bindings/dma/st_fdma.txt b/= Documentation/devicetree/bindings/dma/st_fdma.txt > > > new file mode 100644 > > > index 0000000..1ec7470 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/dma/st_fdma.txt > > > @@ -0,0 +1,76 @@ > > > +* STMicroelectronics Flexible Direct Memory Access Device Tree b= indings > > > + > > > +The FDMA is a general-purpose direct memory access controller ca= pable of > > > +supporting 16 independent DMA channels. It accepts up to 32 DMA = requests. > > > +The FDMA is based on a Slim processor which require a firmware. > > > + > > > +* FDMA Controller > > > + > > > +Required properties: > > > +- compatible : Should be "st,fdma_mpe31" > > > +- reg : Should contain DMA registers location and length > > > +- interrupts : Should contain one interrupt shared by all channe= l > >=20 > > s/channel/channels >=20 > Will fix in v2. >=20 > >=20 > > > +- dma-channels : Number of channels supported by the controller > > > +- #dma-cells : Must be <3>. > >=20 > > any reason three? >=20 > Yes, it is documented further down in the file under DMA Client. >=20 > To make it clearer in V2 I could change to >=20 > "- #dma-cells : Must be <3>. See DMA client section below"? - #dma-cells : Must be <3> 1st cell: Phandle to ... 2nd cell: DMA channel ... 3rd cell: Flags describing ... =20 --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html