From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v3 4/6] [media] c8sectpfe: Update binding to reset-gpios Date: Tue, 1 Sep 2015 10:09:16 +0100 Message-ID: <20150901090916.GM4796@x1> References: <1440784362-31217-1-git-send-email-peter.griffin@linaro.org> <1440784362-31217-5-git-send-email-peter.griffin@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-media-owner@vger.kernel.org To: Javier Martinez Canillas Cc: Peter Griffin , "linux-arm-kernel@lists.infradead.org" , Linux Kernel , srinivas.kandagatla@gmail.com, maxime.coquelin@st.com, patrice.chotard@st.com, Mauro Carvalho Chehab , linux-media@vger.kernel.org, "devicetree@vger.kernel.org" , valentinrothberg@gmail.com, hugues.fruchet@st.com List-Id: devicetree@vger.kernel.org On Tue, 01 Sep 2015, Javier Martinez Canillas wrote: > On Fri, Aug 28, 2015 at 7:52 PM, Peter Griffin wrote: > > gpio.txt documents that GPIO properties should be named > > "[-]gpios", with being the purpose of this > > GPIO for the device. > > > > This change has been done as one atomic commit. > > > > Signed-off-by: Peter Griffin > > Acked-by: Lee Jones > > --- > > Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt | 6 = +++--- > > arch/arm/boot/dts/stihxxx-b2120.dtsi | 4 = ++-- > > drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 2 = +- > > 3 files changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/media/stih407-c8sect= pfe.txt b/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt > > index d4def76..e70d840 100644 > > --- a/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt > > +++ b/Documentation/devicetree/bindings/media/stih407-c8sectpfe.txt > > @@ -35,7 +35,7 @@ Required properties (tsin (child) node): > > > > - tsin-num : tsin id of the InputBlock (must be between 0 to 6= ) > > - i2c-bus : phandle to the I2C bus DT node which the demodula= tors & tuners on this tsin channel are connected. > > -- rst-gpio : reset gpio for this tsin channel. > > +- reset-gpios : reset gpio for this tsin channel. >=20 > The documentation is a bit outdated, the GPIO subsystem supports both > -gpio and -gpios, see commit: >=20 > dd34c37aa3e8 ("gpio: of: Allow -gpio suffix for property names") >=20 > So it makes sense to me to use -gpio instead of -gpios in this case > since is a single GPIO. Also rst is already a descriptive name since > that's how many datasheets name a reset pin. I'm not saying I'm > against this patch, just pointing out since the commit message is a > bit misleading. As I suggested this patch, I feel I must comment. My order of preference would be: reset-gpio reset-gpios rst-gpio rst-gpios This current patch is No2, so it's okay to stay IMHO. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog