From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Andrey Danin <danindrey-JGs/UdohzUI@public.gmane.org>
Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devel-tBiZLqfeLfOHmIFyCCdPziST3g8Odh+X@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ac100-oU9gvf+ajcQ97yFScArB1dHuzzzSOjJt@public.gmane.org,
Laxman Dewangan
<ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Alexandre Courbot
<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
Julian Andres Klode <jak-4HMq4SXA452hPH1hqNUYSQ@public.gmane.org>,
Marc Dietrich <marvin24-Mmb7MZpHnFY@public.gmane.org>
Subject: Re: [PATCH v3 1/4] i2c: tegra: implement slave mode
Date: Tue, 8 Sep 2015 13:46:21 +0200 [thread overview]
Message-ID: <20150908114621.GB15793@katana> (raw)
In-Reply-To: <55D5C4AA.2000307-JGs/UdohzUI@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 881 bytes --]
> Sorry for the long delay. I tried to analyze the issue. Attached patch works
> on AC100 (Misha Komarovsky helped me with testing).
>
> Wolfram could you please try the patch with your environment?
No change, sadly. I don't get slave interrupts.
> Init function is called multuple times. If I2C controller works
> in slave mode, then driver must keep slave registers otherwise
> slave configuration will be reseted.
This patch does not tackle the main issue, though. There should not be a
"slave mode" for the controller. It can be a master and slave
simultaneously and should do the right thing depending on what's
happening on the bus. The Tegra2 manual I have says "The Master can
address the internal slave (for basic testing) or an external 7-bit or
10-bit addressed Slave device." So even a loopback should be possible
(if we trust the manual ;)).
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-09-08 11:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 20:35 [PATCH v3 0/4] arm: tegra: implement NVEC driver using tegra i2c Andrey Danin
[not found] ` <1437424546-30405-1-git-send-email-danindrey-JGs/UdohzUI@public.gmane.org>
2015-07-20 20:35 ` [PATCH v3 1/4] i2c: tegra: implement slave mode Andrey Danin
2015-07-24 9:27 ` Wolfram Sang
2015-07-24 10:18 ` Andrey Danin
[not found] ` <55B210F4.6030700-JGs/UdohzUI@public.gmane.org>
2015-07-24 10:52 ` Wolfram Sang
2015-08-20 12:14 ` Andrey Danin
[not found] ` <55D5C4AA.2000307-JGs/UdohzUI@public.gmane.org>
2015-09-08 11:46 ` Wolfram Sang [this message]
2015-09-08 12:31 ` Andrey Danin
2015-07-20 20:35 ` [PATCH v3 2/4] staging/nvec: reimplement on top of tegra i2c driver Andrey Danin
[not found] ` <1437424546-30405-3-git-send-email-danindrey-JGs/UdohzUI@public.gmane.org>
2015-07-20 22:18 ` Stephen Warren
2015-07-20 20:35 ` [PATCH v3 3/4] staging/nvec: remove old code Andrey Danin
2015-07-20 20:35 ` [PATCH v3 4/4] dt: paz00: define nvec as child of i2c bus Andrey Danin
2015-07-20 22:19 ` Stephen Warren
[not found] ` <55AD73F4.2050502-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2015-07-21 6:35 ` Andrey Danin
2015-07-21 8:25 ` Marc Dietrich
2015-07-21 8:51 ` Andrey Danin
[not found] ` <55AE0803.10603-JGs/UdohzUI@public.gmane.org>
2015-07-21 11:57 ` Marc Dietrich
2015-07-21 20:52 ` Wolfram Sang
2015-07-21 8:38 ` [PATCH v3 0/4] arm: tegra: implement NVEC driver using tegra i2c Andrey Danin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150908114621.GB15793@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=ac100-oU9gvf+ajcQ97yFScArB1dHuzzzSOjJt@public.gmane.org \
--cc=danindrey-JGs/UdohzUI@public.gmane.org \
--cc=devel-tBiZLqfeLfOHmIFyCCdPziST3g8Odh+X@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=jak-4HMq4SXA452hPH1hqNUYSQ@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=marvin24-Mmb7MZpHnFY@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox