From: Alexander Couzens <lynxis-qyMx1GtpvWw@public.gmane.org>
To: Alban <albeu-GANU6spQydw@public.gmane.org>
Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org,
Ralf Baechle <ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] MIPS: ath79: set missing irq ack handler for ar7100-misc-intc irq chip
Date: Wed, 9 Sep 2015 11:04:06 +0200 [thread overview]
Message-ID: <20150909110406.2e4a4f97@lazus.yip> (raw)
In-Reply-To: <20150903103245.21dc9dd7@avionic-0020>
[-- Attachment #1: Type: text/plain, Size: 776 bytes --]
On Thu, 3 Sep 2015 10:32:45 +0200
Alban <albeu-GANU6spQydw@public.gmane.org> wrote:
> > -IRQCHIP_DECLARE(ath79_misc_intc, "qca,ar7100-misc-intc",
> > - ath79_misc_intc_of_init);
> > +
> > +static int __init ar7100_misc_intc_of_init(
> > + struct device_node *node, struct device_node *parent)
> > +{
> > + pr_info("IRQ: Setup ar7100 misc IRQ controller from
> > devicetree.\n");
>
> Debug left over?
I'll remove it in next patch. I added it because you mentioned a log
message in your last review.
> On Mon, 10 Aug 2015 20:11:14 +0200
> Alban <albeu-GANU6spQydw@public.gmane.org> wrote:
>> Mon, 10 Aug 2015 20:11:14 +0200
>> A log message would be nice. IMHO it should mention that the ACK
>> callbacks have been missed when introducing OF support.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-09-09 9:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 3:34 [PATCH 0/2] ath79 misc irq controller Alexander Couzens
[not found] ` <1441251262-13335-1-git-send-email-lynxis-qyMx1GtpvWw@public.gmane.org>
2015-09-03 3:34 ` [PATCH 1/2] MIPS: ath79: set missing irq ack handler for ar7100-misc-intc irq chip Alexander Couzens
[not found] ` <1441251262-13335-2-git-send-email-lynxis-qyMx1GtpvWw@public.gmane.org>
2015-09-03 8:32 ` Alban
2015-09-09 9:04 ` Alexander Couzens [this message]
[not found] ` <20150909110406.2e4a4f97-HsCBy8pOd9l4Eiagz67IpQ@public.gmane.org>
2015-09-09 13:52 ` Alban
2015-09-03 3:34 ` [PATCH 2/2] MIPS: ath79: add irq chip ar7240-misc-intc Alexander Couzens
[not found] ` <1441251262-13335-3-git-send-email-lynxis-qyMx1GtpvWw@public.gmane.org>
2015-09-03 8:34 ` Alban
2015-09-03 10:23 ` Mark Rutland
-- strict thread matches above, loose matches on Subject: below --
2015-09-19 4:26 [PATCH 0/2] v3 ath79 misc irq controller Alexander Couzens
[not found] ` <1442636780-2891-1-git-send-email-lynxis-qyMx1GtpvWw@public.gmane.org>
2015-09-19 4:26 ` [PATCH 1/2] MIPS: ath79: set missing irq ack handler for ar7100-misc-intc irq chip Alexander Couzens
2015-09-22 10:23 ` Thomas Gleixner
2015-09-22 17:09 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150909110406.2e4a4f97@lazus.yip \
--to=lynxis-qymx1gtpvww@public.gmane.org \
--cc=albeu-GANU6spQydw@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).