Re: [PATCH v2 08/13] power: bq24257: Add charge type setting support

Laurentiu Palcu
2015-09-10T13:56:22Z

On Tue, Sep 08, 2015 at 07:12:32PM -0500, Andreas Dannenberg wrote:
> The bq2425x devices support charging with a configurable charge current
> i_chg or a specific fixed low-current in what's called Low Charge mode.
> This patch exposes access to the Low Charge mode through a POWER_
> SUPPLY_PROP_CHARGE_TYPE sysfs property value of POWER_SUPPLY_CHARGE_
> TYPE_TRICKLE. It also allows to completely disable charging if desired
> by setting the property to POWER_SUPPLY_CHARGE_TYPE_NONE. Normal
> charging with the configured i_chg current is activated through
> POWER_SUPPLY_CHARGE_TYPE_FAST (default).
>
> Signed-off-by: Andreas Dannenberg <dannenberg-l0cyMroinI0@public.gmane.org>

I have some questions here. Are there any cases in the wild, when
userspace selects the charging type (apart from testing purposes)? And
if yes, how is userspace supposed to detect/decide when to switch from
trickle to fast?

I have the strange feeling that we're adding properties that will never
be used... Other people's opinions are welcomed too.

laurentiu
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html