From: Laurentiu Palcu <laurentiu.palcu@intel.com>
To: Andreas Dannenberg <dannenberg@ti.com>
Cc: Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 07/13] power: bq24257: Extend scope of mutex protection
Date: Thu, 10 Sep 2015 16:43:10 +0300 [thread overview]
Message-ID: <20150910134309.GI21512@lpalcu-desk> (raw)
In-Reply-To: <1441757557-7266-8-git-send-email-dannenberg@ti.com>
On Tue, Sep 08, 2015 at 07:12:31PM -0500, Andreas Dannenberg wrote:
> This commit extends the use of the existing mutex to pave the way for
> using direct device access inside sysfs getter/setter routines in a
> way that the access during interrupts and timer routines does not
> interfere with device access by the CPU or between multiple cores.
>
> This also addresses a potential race condition that could be caused
> by bq24257_irq_handler_thread() and bq24257_iilimit_autoset() accessing
> the device simultaneously.
What potential race? AFAIK, we're doing all the operations through
regmap, and regmap operations are serialized. It has its own mutex for
this. Unless I got it all wrong...
So, IMHO, you don't need to protect against simultaneous device access.
It's taken care of by regmap. Chip state data protection should be enough.
laurentiu
next prev parent reply other threads:[~2015-09-10 13:43 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-09 0:12 [PATCH v2 00/13] power: bq24257: Add support for bq24250/bq24251 Andreas Dannenberg
2015-09-09 0:12 ` [PATCH v2 01/13] power: bq24257: Add bit definition for temp sense enable Andreas Dannenberg
2015-09-10 12:31 ` Laurentiu Palcu
2015-09-09 0:12 ` [PATCH v2 02/13] power: bq24257: Add basic support for bq24250/bq24251 Andreas Dannenberg
2015-09-10 12:42 ` Laurentiu Palcu
2015-09-10 16:19 ` Andreas Dannenberg
2015-09-09 0:12 ` [PATCH v2 03/13] power: bq24257: Allow manual setting of input current limit Andreas Dannenberg
[not found] ` <1441757557-7266-4-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-10 12:50 ` Laurentiu Palcu
2015-09-09 0:12 ` [PATCH v2 04/13] power: bq24257: Add SW-based approach for Power Good determination Andreas Dannenberg
[not found] ` <1441757557-7266-5-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-10 12:57 ` Laurentiu Palcu
2015-09-09 0:12 ` [PATCH v2 05/13] power: bq24257: Add over voltage protection setting support Andreas Dannenberg
[not found] ` <1441757557-7266-6-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-10 13:07 ` Laurentiu Palcu
2015-09-09 0:12 ` [PATCH v2 06/13] power: bq24257: Add input DPM voltage threshold " Andreas Dannenberg
2015-09-10 13:27 ` Laurentiu Palcu
2015-09-09 0:12 ` [PATCH v2 07/13] power: bq24257: Extend scope of mutex protection Andreas Dannenberg
2015-09-10 13:43 ` Laurentiu Palcu [this message]
2015-09-10 17:05 ` Andreas Dannenberg
2015-09-09 0:12 ` [PATCH v2 08/13] power: bq24257: Add charge type setting support Andreas Dannenberg
[not found] ` <1441757557-7266-9-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-10 13:56 ` Laurentiu Palcu
2015-09-10 18:50 ` Andreas Dannenberg
2015-09-09 0:12 ` [PATCH v2 09/13] power: bq24257: Allow input current limit sysfs access Andreas Dannenberg
2015-09-10 14:06 ` Laurentiu Palcu
[not found] ` <1441757557-7266-1-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-09 0:12 ` [PATCH v2 10/13] power: bq24257: Add various device-specific sysfs properties Andreas Dannenberg
[not found] ` <1441757557-7266-11-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-10 14:13 ` Laurentiu Palcu
2015-09-10 18:53 ` Andreas Dannenberg
2015-09-09 0:12 ` [PATCH v2 11/13] power: bq24257: Add platform data based initialization Andreas Dannenberg
2015-09-10 14:40 ` Laurentiu Palcu
2015-09-10 19:49 ` Andreas Dannenberg
2015-09-09 0:12 ` [PATCH v2 13/13] dt: power: bq2425x-charger: Cover additional devices Andreas Dannenberg
2015-09-09 0:27 ` Krzysztof Kozlowski
2015-09-09 2:48 ` Andreas Dannenberg
2015-09-09 4:58 ` Krzysztof Kozlowski
2015-09-09 20:15 ` Andreas Dannenberg
2015-09-10 0:15 ` Krzysztof Kozlowski
2015-09-10 15:00 ` Laurentiu Palcu
2015-09-10 21:05 ` Andreas Dannenberg
2015-09-10 20:57 ` Andreas Dannenberg
2015-09-11 0:34 ` Krzysztof Kozlowski
2015-09-11 14:47 ` Andreas Dannenberg
2015-09-10 12:26 ` [PATCH v2 00/13] power: bq24257: Add support for bq24250/bq24251 Laurentiu Palcu
2015-09-10 21:26 ` Andreas Dannenberg
2015-09-11 8:26 ` Laurentiu Palcu
2015-09-11 15:06 ` Andreas Dannenberg
2015-09-09 0:12 ` [PATCH v2 12/13] power: bq24257: Renaming for consistency Andreas Dannenberg
2015-09-10 14:41 ` Laurentiu Palcu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150910134309.GI21512@lpalcu-desk \
--to=laurentiu.palcu@intel.com \
--cc=dannenberg@ti.com \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=k.kozlowski@samsung.com \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox