From: Brian Norris <computersforpeace@gmail.com>
To: Bayi Cheng <bayi.cheng@mediatek.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Daniel Kurtz <djkurtz@chromium.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH 1/3] doc: dt: add documentation for Mediatek spi-nor controller
Date: Fri, 11 Sep 2015 14:49:07 -0700 [thread overview]
Message-ID: <20150911214907.GE11487@google.com> (raw)
In-Reply-To: <1441705796-11365-2-git-send-email-bayi.cheng@mediatek.com>
One more thing:
On Tue, Sep 08, 2015 at 05:49:54PM +0800, Bayi Cheng wrote:
> +- clocks: spi nor source clock
^^ you only list one clock here
> +- clock-names: "spi_clk", "axi_clk", "mux_clk", "sf_clk"
But you have 4 names here.
...
> + clocks = <&pericfg CLK_PERI_SPI>,
> + <&topckgen CLK_TOP_AXI_SEL>,
> + <&topckgen CLK_TOP_UNIVPLL2_D8>,
> + <&topckgen CLK_TOP_SPINFI_IFR_SEL>;
And you provide 4 clocks.
> + clock-names = "spi_clk", "axi_clk", "mux_clk", "sf_clk";
Please list all 4 under the "clocks" property, not just under the
"clock-names" property.
Brian
next prev parent reply other threads:[~2015-09-11 21:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-08 9:49 [PATCH 0/3] Mediatek SPI-NOR flash driver Bayi Cheng
2015-09-08 9:49 ` [PATCH 1/3] doc: dt: add documentation for Mediatek spi-nor controller Bayi Cheng
2015-09-08 11:34 ` Jagan Teki
[not found] ` <CAD6G_RR5W8_4d_gcTD=h9EBhwWUzsEmyNK+pYGq82GEHDV4=ig-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-15 6:49 ` bayi.cheng
[not found] ` <1441705796-11365-2-git-send-email-bayi.cheng-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-09-09 5:47 ` Sascha Hauer
[not found] ` <20150909054734.GC18700-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-09-15 6:39 ` bayi.cheng
2015-09-11 21:47 ` Brian Norris
2015-09-11 21:49 ` Brian Norris [this message]
[not found] ` <20150911214907.GE11487-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2015-09-15 6:53 ` bayi.cheng
[not found] ` <1441705796-11365-1-git-send-email-bayi.cheng-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-09-08 9:49 ` [PATCH 2/3] mtd: mtk-nor: mtk serial flash controller driver Bayi Cheng
2015-09-09 6:37 ` Sascha Hauer
[not found] ` <20150909063701.GD18700-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-09-09 13:00 ` Lothar Waßmann
[not found] ` <20150909150050.44d2b197-VjFSrY7JcPWvSplVBqRQBQ@public.gmane.org>
2015-09-15 16:37 ` bayi.cheng
2015-09-15 16:23 ` bayi.cheng
2015-09-08 9:49 ` [PATCH 3/3] arm64: dts: mt8173: Add nor flash node Bayi Cheng
[not found] ` <1441705796-11365-4-git-send-email-bayi.cheng-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-09-08 11:53 ` Jagan Teki
[not found] ` <CAD6G_RTR2r8ETMQ14uGosRn-85sssvVsFT4BjK9SkVSfMkG8Dw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-08 15:18 ` Ezequiel Garcia
[not found] ` <CAAEAJfCg+O=b9pfndG2WfxKVk9gvcqHUL0MV4fDpHj_9CaCBbQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-08 23:46 ` Rob Herring
[not found] ` <55EF7346.5040607-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-09-11 9:51 ` bayi.cheng
2015-09-11 21:56 ` Brian Norris
2015-09-11 9:49 ` bayi.cheng
2015-09-11 9:47 ` bayi.cheng
-- strict thread matches above, loose matches on Subject: below --
2015-09-17 8:36 [PATCH 1/3] doc: dt: add documentation for Mediatek spi-nor controller Bayi Cheng
[not found] ` <1442478994-12467-1-git-send-email-bayi.cheng-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-09-17 9:02 ` bayi.cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150911214907.GE11487@google.com \
--to=computersforpeace@gmail.com \
--cc=bayi.cheng@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=djkurtz@chromium.org \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).