devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sean Young <sean-hENCXIMQXOg@public.gmane.org>
To: Eric Nelson <eric-SeqgQ6RdavfQT0dZR+AlfA@public.gmane.org>
Cc: linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	pawel.moll-5wv7dgnIgG8@public.gmane.org,
	mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
	galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	patrice.chotard-qxv4g6HH51o@public.gmane.org,
	fabf-AgBVmzD5pcezQB+pC5nmwQ@public.gmane.org,
	wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org,
	heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	otavio-fKevB0iiKLMBZ+LybsDmbA@public.gmane.org
Subject: Re: [PATCH][resend] rc: gpio-ir-recv: allow flush space on idle
Date: Mon, 14 Sep 2015 11:00:44 +0100	[thread overview]
Message-ID: <20150914100044.GA21149@gofer.mess.org> (raw)
In-Reply-To: <1441980024-1944-1-git-send-email-eric-SeqgQ6RdavfQT0dZR+AlfA@public.gmane.org>

On Fri, Sep 11, 2015 at 07:00:24AM -0700, Eric Nelson wrote:
> Many decoders require a trailing space (period without IR illumination)
> to be delivered before completing a decode.
> 
> Since the gpio-ir-recv driver only delivers events on gpio transitions,
> a single IR symbol (caused by a quick touch on an IR remote) will not
> be properly decoded without the use of a timer to flush the tail end
> state of the IR receiver.

This is a problem other IR drivers suffer from too. It might be better
to send a IR timeout event like st_rc_send_lirc_timeout() in st_rc.c,
with the duration set to what the timeout was. That is what irraw 
timeouts are for; much better than fake transitions.

> This patch adds an optional device tree node "flush-ms" which, if
> present, will use a jiffie-based timer to complete the last pulse
> stream and allow decode.

A common value for this is 100ms, I'm not sure what use it has to have
it configurable. It's nice to have it exposed in rc_dev->timeout.


Sean
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-09-14 10:00 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-11 14:00 [PATCH][resend] rc: gpio-ir-recv: allow flush space on idle Eric Nelson
     [not found] ` <1441980024-1944-1-git-send-email-eric-SeqgQ6RdavfQT0dZR+AlfA@public.gmane.org>
2015-09-14 10:00   ` Sean Young [this message]
2015-09-14 14:34     ` Eric Nelson
2015-09-14 14:54       ` Sean Young
2015-09-14 15:05         ` Eric Nelson
2015-09-14 15:35           ` Sean Young
2015-09-21 19:08 ` [PATCH V2 0/2] rc: Add timeout support to gpio-ir-recv Eric Nelson
2015-09-21 19:08 ` Eric Nelson
2015-09-21 19:08   ` [PATCH V2 1/2] rc-core: define a default timeout for drivers Eric Nelson
     [not found]     ` <1442862524-3694-2-git-send-email-eric-SeqgQ6RdavfQT0dZR+AlfA@public.gmane.org>
2015-10-03 14:25       ` Mauro Carvalho Chehab
     [not found]         ` <20151003112510.54fe2a25-+RedX5hVuTR+urZeOPWqwQ@public.gmane.org>
2015-10-03 14:52           ` Eric Nelson
2015-10-03 15:18         ` Eric Nelson
2015-09-21 19:08   ` [PATCH V2 2/2] rc: gpio-ir-recv: add timeout on idle Eric Nelson
2015-09-23 13:26     ` Sean Young
2015-09-23 13:52       ` Eric Nelson
     [not found]         ` <5602AE95.9000505-SeqgQ6RdavfQT0dZR+AlfA@public.gmane.org>
2015-09-23 14:07           ` [PATCH V3 " Eric Nelson
     [not found]             ` <1443017228-16499-1-git-send-email-eric-SeqgQ6RdavfQT0dZR+AlfA@public.gmane.org>
2015-09-23 14:26               ` Sean Young
2015-10-03 14:27   ` [PATCH V2 0/2] rc: Add timeout support to gpio-ir-recv Mauro Carvalho Chehab
2015-10-03 15:10     ` Eric Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150914100044.GA21149@gofer.mess.org \
    --to=sean-hencximqxog@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=eric-SeqgQ6RdavfQT0dZR+AlfA@public.gmane.org \
    --cc=fabf-AgBVmzD5pcezQB+pC5nmwQ@public.gmane.org \
    --cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
    --cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
    --cc=linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org \
    --cc=otavio-fKevB0iiKLMBZ+LybsDmbA@public.gmane.org \
    --cc=patrice.chotard-qxv4g6HH51o@public.gmane.org \
    --cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).