From: Tejun Heo <tj@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Fengguang Wu <fengguang.wu@intel.com>,
Yuantian Tang <Yuantian.Tang@freescale.com>,
"hdegoede@redhat.com" <hdegoede@redhat.com>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings
Date: Mon, 14 Sep 2015 12:00:41 -0400 [thread overview]
Message-ID: <20150914160041.GD20047@mtj.duckdns.org> (raw)
In-Reply-To: <4524877.YJljz8o2LZ@wuerfel>
Hello, Arnd.
On Mon, Sep 14, 2015 at 09:45:33AM +0200, Arnd Bergmann wrote:
> In general, we really want to leave drivers with a COMPILE_TEST dependency
> so they at least get cross-built on x86, ideally on all architectures.
Yeah, as long as it doesn't trigger silly warnings or errors on x86,
COMPILE_TEST is usually a good idea.
> Does something like the below help? I think we really just need to help
> gcc a little to see the obvious.
We already tried cachine qoriq_priv->type in a local. Not sure this
would make much difference. It looks like the warning goes away with
newer gcc. I'm inclined to just leave it as-is.
Thanks.
--
tejun
prev parent reply other threads:[~2015-09-14 16:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-09 9:16 [PATCH] ahci: qoriq: fixed using uninitialized variable warnings Yuantian.Tang
2015-09-09 10:57 ` Hans de Goede
2015-09-09 14:01 ` Tejun Heo
2015-09-10 6:17 ` Yuantian Tang
2015-09-11 5:27 ` Yuantian Tang
2015-09-11 13:54 ` Tejun Heo
2015-09-14 3:02 ` Yuantian Tang
2015-09-14 4:04 ` Fengguang Wu
2015-09-14 6:51 ` Yuantian Tang
2015-09-14 6:54 ` Fengguang Wu
2015-09-14 7:45 ` Arnd Bergmann
2015-09-14 16:00 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150914160041.GD20047@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=Yuantian.Tang@freescale.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=fengguang.wu@intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).