From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings Date: Mon, 14 Sep 2015 12:00:41 -0400 Message-ID: <20150914160041.GD20047@mtj.duckdns.org> References: <1441790182-20248-1-git-send-email-Yuantian.Tang@freescale.com> <20150914065432.GA25168@wfg-t540p.sh.intel.com> <4524877.YJljz8o2LZ@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4524877.YJljz8o2LZ@wuerfel> Sender: linux-ide-owner@vger.kernel.org To: Arnd Bergmann Cc: Fengguang Wu , Yuantian Tang , "hdegoede@redhat.com" , "linux-ide@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" List-Id: devicetree@vger.kernel.org Hello, Arnd. On Mon, Sep 14, 2015 at 09:45:33AM +0200, Arnd Bergmann wrote: > In general, we really want to leave drivers with a COMPILE_TEST dependency > so they at least get cross-built on x86, ideally on all architectures. Yeah, as long as it doesn't trigger silly warnings or errors on x86, COMPILE_TEST is usually a good idea. > Does something like the below help? I think we really just need to help > gcc a little to see the obvious. We already tried cachine qoriq_priv->type in a local. Not sure this would make much difference. It looks like the warning goes away with newer gcc. I'm inclined to just leave it as-is. Thanks. -- tejun