From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Vignesh R <vigneshr-l0cyMroinI0@public.gmane.org>
Cc: Benoit Cousson <bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Brian Norris
<computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 3/5] mtd: devices: m25p80: add support for mmap read request
Date: Mon, 14 Sep 2015 19:27:04 +0100 [thread overview]
Message-ID: <20150914182704.GD12027@sirena.org.uk> (raw)
In-Reply-To: <1441355402-6837-4-git-send-email-vigneshr-l0cyMroinI0@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 394 bytes --]
On Fri, Sep 04, 2015 at 02:00:00PM +0530, Vignesh R wrote:
> + if (spi->master->spi_mtd_mmap_read) {
> + return spi->master->spi_mtd_mmap_read(spi, from, len,
> + retlen, buf,
> + nor->read_opcode,
> + nor->addr_width,
> + dummy);
> + }
We should be calling some API provided by the SPI core here, not peering
directly into the ops struture.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-09-14 18:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 8:29 [PATCH 0/5] Add memory mapped read support for ti-qspi Vignesh R
2015-09-04 8:29 ` [PATCH 1/5] spi: introduce mmap read support for spi flash devices Vignesh R
[not found] ` <1441355402-6837-2-git-send-email-vigneshr-l0cyMroinI0@public.gmane.org>
2015-09-04 11:25 ` Jagan Teki
[not found] ` <CAD6G_RT8Q+Uyp1ZjzHf54Tno1wHm0SmLKEwRAe2gkdp772FD9A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-14 18:35 ` Mark Brown
2015-09-16 10:07 ` Vignesh R
[not found] ` <20150914183553.GE12027-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-09-16 12:46 ` Jagan Teki
[not found] ` <CAD6G_RQOazkS7KHrG75wgMXx1cH_pKjx43Mve6fz1qOJGPpq9w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-16 15:24 ` Mark Brown
2015-09-16 15:30 ` Michal Suchanek
2015-09-14 18:37 ` Mark Brown
2015-09-16 10:08 ` Vignesh R
[not found] ` <55F93F89.7060708-l0cyMroinI0@public.gmane.org>
2015-09-16 10:56 ` Mark Brown
2015-09-18 12:10 ` Vignesh R
2015-09-04 8:29 ` [PATCH 2/5] spi: spi-ti-qspi: add mmap mode read support Vignesh R
2015-09-14 18:26 ` Mark Brown
2015-09-16 10:07 ` Vignesh R
2015-09-04 8:30 ` [PATCH 3/5] mtd: devices: m25p80: add support for mmap read request Vignesh R
[not found] ` <1441355402-6837-4-git-send-email-vigneshr-l0cyMroinI0@public.gmane.org>
2015-09-14 18:27 ` Mark Brown [this message]
2015-09-16 10:07 ` Vignesh R
[not found] ` <1441355402-6837-1-git-send-email-vigneshr-l0cyMroinI0@public.gmane.org>
2015-09-04 8:30 ` [PATCH 4/5] ARM: dts: DRA7: add entry for qspi mmap region Vignesh R
2015-09-04 8:30 ` [PATCH 5/5] ARM: dts: AM4372: " Vignesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150914182704.GD12027@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
--cc=vigneshr-l0cyMroinI0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).