From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH 5/6] PCI: generic: Pass proper starting bus number to pci_scan_root_bus(). Date: Tue, 15 Sep 2015 18:55:20 +0100 Message-ID: <20150915175519.GN31157@arm.com> References: <1442013719-5001-1-git-send-email-ddaney.cavm@gmail.com> <1442013719-5001-6-git-send-email-ddaney.cavm@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1442013719-5001-6-git-send-email-ddaney.cavm@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: David Daney Cc: "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Rob Herring , Frank Rowand , "grant.likely@linaro.org" , Bjorn Helgaas , "linux-pci@vger.kernel.org" , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "linux-arm-kernel@lists.infradead.org" , David Daney , lorenzo.pieralisi@arm.com List-Id: devicetree@vger.kernel.org On Sat, Sep 12, 2015 at 12:21:58AM +0100, David Daney wrote: > From: David Daney > > If the bus is being configured with a bus-range that does not start at > zero, pass that starting bus number to pci_scan_root_bus(). Passing > the incorrect value of zero causes attempted config accesses outside > of the supported range, which cascades to an OOPs spew and eventual > kernel panic. > > Signed-off-by: David Daney > --- > drivers/pci/host/pci-host-generic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/host/pci-host-generic.c b/drivers/pci/host/pci-host-generic.c > index fce5bf7..8219c0b 100644 > --- a/drivers/pci/host/pci-host-generic.c > +++ b/drivers/pci/host/pci-host-generic.c > @@ -265,7 +265,7 @@ static int gen_pci_probe(struct platform_device *pdev) > if (!pci_has_flag(PCI_PROBE_ONLY)) > pci_add_flags(PCI_REASSIGN_ALL_RSRC | PCI_REASSIGN_ALL_BUS); > > - bus = pci_scan_root_bus(dev, 0, > + bus = pci_scan_root_bus(dev, pci->cfg.bus_range->start, > &pci->cfg.ops.ops, pci, &pci->resources); > if (!bus) { > dev_err(dev, "Scanning rootbus failed"); Acked-by: Will Deacon Will