From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 1/3] mfd: axp20x: Rename supply names for AXP221 DC1SW and DC5LDO regulators Date: Wed, 16 Sep 2015 12:03:54 +0200 Message-ID: <20150916100354.GW4684@lukather> References: <1442372732-27434-1-git-send-email-wens@csie.org> <1442372732-27434-2-git-send-email-wens@csie.org> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="OEa2bCMk+rg6xBXy" Return-path: Content-Disposition: inline In-Reply-To: <1442372732-27434-2-git-send-email-wens-jdAy2FN1RRM@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Chen-Yu Tsai Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Liam Girdwood , Mark Brown , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org --OEa2bCMk+rg6xBXy Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline On Wed, Sep 16, 2015 at 11:05:30AM +0800, Chen-Yu Tsai wrote: > The DC1SW and DC5LDO regulators in the AXP221 are internally chained > to DCDC1 and DCDC5, hence the names. The original bindings used the > parent regulator names for the supply regulator property. This causes > some confusion when we actually use it in the dts: > > axp221 { > /* self supplying? */ > dcdc1-supply = <&dcdc1>; > dcdc5-supply = <&dcdc5>; > > dcdc1: dcdc1 { > ... > }; > > dcdc5: dcdc5 { > ... > }; > }; > > Change them to the downstream regulator names, or "dc1sw" and "dc5ldo" > respectively. > > Signed-off-by: Chen-Yu Tsai Acked-by: Maxime Ripard Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --OEa2bCMk+rg6xBXy--