Re: [PATCH] regulator: tps65023: add device tree support

[Thomas Elste <thomas.elste-cSCHQGRfioA@public.gmane.org>]

> > +static struct regulator_init_data*
> > +	of_get_tps65023_platform_data(struct device *dev)
> > +{
> > +	struct regulator_init_data *reg_data;
> > +	struct device_node *np = dev->of_node;
> > +	struct device_node *regulators;
> > +	struct of_regulator_match *matches;
> > +	int idx, count, ret;
> > +
> > +	regulators = of_get_child_by_name(np, "regulators");
> > +	if (!regulators) {
> > +		dev_err(dev, "Regulator node not found\n");
> > +		return NULL;
> > +	}
> 
> There's now core support for this so no need to open code in the
> driver
> - set of_match and regulators_node in the regulator_desc instead.
Thanks for reviewing. I'll change the patch to matching regulator nodes
via regulator core code.

And I will use a separate patch for the binding document (just found
Documentation/devicetree/bindings/submitting-patches.txt).


Best regards
Thomas

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html