From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH v2 1/2] input: Add Qualcomm PM8941 power key driver Date: Sun, 20 Sep 2015 21:48:58 -0700 Message-ID: <20150921044858.GP13472@usrtlx11787.corpusers.net> References: <1422058747-13486-1-git-send-email-bjorn.andersson@sonymobile.com> <1422058747-13486-2-git-send-email-bjorn.andersson@sonymobile.com> <1442316985.15519.7.camel@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <1442316985.15519.7.camel@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org To: "Ivan T. Ivanov" Cc: "Cavin, Courtney" , Dmitry Torokhov , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Grant Likely , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-input@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" List-Id: devicetree@vger.kernel.org On Tue 15 Sep 04:36 PDT 2015, Ivan T. Ivanov wrote: > > On Fri, 2015-01-23 at 16:19 -0800, Bjorn Andersson wrote: > > From: Courtney Cavin cavin@sonymobile.com> > > > > Signed-off-by: Courtney Cavin cavin@sonymobile.com> > > Signed-off-by: Bjorn Andersson andersson@sonymobile.com> > > > > > > > > > +config INPUT_PM8941_PWRKEY > > + tristate "Qualcomm PM8941 power key support" > > + depends on MFD_SPMI_PMIC > > + help > > + Say Y here if you want support for the power key usually found > > + on boards using a Qualcomm PM8941 compatible PMIC. > > + > > Hi Bjorn, Courtney, > > Do you plan to extend this driver to support RESIN_N PMIC input? > It's way down on the todo-list, so not right now. > It looks like the same downstream "qcom,qpnp-power-on" handle > this functionality for recent PMIC versions. > Right, it seems to be functionality in the PON block. > What will be the best way to add this new functionality, extend > this driver, write new one...? > Perhaps the naming of the driver isn't the best in the end, but I think it should be implemented by the same driver... Regards, Bjorn