From: Lee Jones <lee.jones@linaro.org>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-sunxi <linux-sunxi@googlegroups.com>,
devicetree <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/3] mfd: axp20x: Rename supply names for AXP221 DC1SW and DC5LDO regulators
Date: Tue, 22 Sep 2015 23:06:49 +0100 [thread overview]
Message-ID: <20150922220649.GJ3442@x1> (raw)
In-Reply-To: <CAGb2v65pPzZsb0X5WQ6-X9tEqvNYYGPiLrKxR18+nZ0P4R-VCA@mail.gmail.com>
On Sun, 20 Sep 2015, Chen-Yu Tsai wrote:
> Hi Lee,
>
> On Sun, Sep 20, 2015 at 12:17 PM, Lee Jones <lee.jones@linaro.org> wrote:
> > On Wed, 16 Sep 2015, Chen-Yu Tsai wrote:
> >
> >> The DC1SW and DC5LDO regulators in the AXP221 are internally chained
> >> to DCDC1 and DCDC5, hence the names. The original bindings used the
> >> parent regulator names for the supply regulator property. This causes
> >> some confusion when we actually use it in the dts:
> >>
> >> axp221 {
> >> /* self supplying? */
> >> dcdc1-supply = <&dcdc1>;
> >> dcdc5-supply = <&dcdc5>;
> >>
> >> dcdc1: dcdc1 {
> >> ...
> >> };
> >>
> >> dcdc5: dcdc5 {
> >> ...
> >> };
> >> };
> >>
> >> Change them to the downstream regulator names, or "dc1sw" and "dc5ldo"
> >> respectively.
> >>
> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> >> ---
> >> Documentation/devicetree/bindings/mfd/axp20x.txt | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > Applied, thanks.
>
> Mark (in his reply) has a point. If these are internally connect, we
> should just remove them from the bindings, and associate them in the
> driver.
>
> I'm looking into this. In the mean time, could you drop this one?
Patch removed.
> >> diff --git a/Documentation/devicetree/bindings/mfd/axp20x.txt b/Documentation/devicetree/bindings/mfd/axp20x.txt
> >> index 41811223e5be..8e79252b1e7c 100644
> >> --- a/Documentation/devicetree/bindings/mfd/axp20x.txt
> >> +++ b/Documentation/devicetree/bindings/mfd/axp20x.txt
> >> @@ -60,8 +60,8 @@ DCDC2 : DC-DC buck : vin2-supply
> >> DCDC3 : DC-DC buck : vin3-supply
> >> DCDC4 : DC-DC buck : vin4-supply
> >> DCDC5 : DC-DC buck : vin5-supply
> >> -DC1SW : On/Off Switch : dcdc1-supply : DCDC1 secondary output
> >> -DC5LDO : LDO : dcdc5-supply : input from DCDC5
> >> +DC1SW : On/Off Switch : dc1sw-supply : DCDC1 secondary output
> >> +DC5LDO : LDO : dc5ldo-supply : input from DCDC5
> >> ALDO1 : LDO : aldoin-supply : shared supply
> >> ALDO2 : LDO : aldoin-supply : shared supply
> >> ALDO3 : LDO : aldoin-supply : shared supply
> >
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-09-22 22:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 3:05 [PATCH 0/3] regulators: axp20x: Rename AXP221 DC1SW and DC5LDO supply names Chen-Yu Tsai
[not found] ` <1442372732-27434-1-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2015-09-16 3:05 ` [PATCH 1/3] mfd: axp20x: Rename supply names for AXP221 DC1SW and DC5LDO regulators Chen-Yu Tsai
[not found] ` <1442372732-27434-2-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2015-09-16 10:03 ` Maxime Ripard
2015-09-19 18:06 ` Mark Brown
2015-09-20 4:17 ` Lee Jones
2015-09-20 10:17 ` Chen-Yu Tsai
2015-09-22 22:06 ` Lee Jones [this message]
2015-09-16 3:05 ` [PATCH 2/3] regulators: axp20x: Rename supply names for AXP221 DC1SW and DC5LDO Chen-Yu Tsai
[not found] ` <1442372732-27434-3-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2015-09-16 10:04 ` Maxime Ripard
2015-09-16 3:05 ` [PATCH 3/3] ARM: dts: sun6i: hummingbird: Rename AXP221 DC1SW and DC5LDO supply names Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150922220649.GJ3442@x1 \
--to=lee.jones@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).