From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [RESEND PATCHv3] arm64: dts: Add base stratix 10 dtsi Date: Wed, 23 Sep 2015 06:54:50 +0100 Message-ID: <20150923055450.GA4883@svinekod> References: <1442353625-4552-1-git-send-email-dinguyen@opensource.altera.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1442353625-4552-1-git-send-email-dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org" Cc: Catalin Marinas , Will Deacon , "robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org" , "galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org" , Pawel Moll , "dinh.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org > +/ { > + compatible = "altr,socfpga-stratix10"; > + #address-cells = <2>; > + #size-cells = <2>; [...] > + soc { > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "simple-bus"; > + device_type = "soc"; > + interrupt-parent = <&intc>; As far as I am aware, this requires a (non-empty) ranges property, given the parent node has {address,size}-cells = <2>. Does the kernel not complain currently? Otherwise this looks OK to me. Please fix the rangers property and ask for this to be taken via arm-soc. I note neither Arnd nor Olof are on Cc currently. Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html