Re: [PATCH v6 03/14] power: bq24257: Streamline input current limit setup

[Laurentiu Palcu <laurentiu.palcu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]

On Thu, Sep 24, 2015 at 10:26:47PM -0500, Andreas Dannenberg wrote:
[...]
> -	if (reset_iilimit) {
> +		/* reset input current limit */
>  		ret = bq24257_field_write(bq, F_IILIMIT, IILIMIT_500);
>  		if (ret < 0)
>  			goto error;
> -	} else if (config_iilimit) {
> -		schedule_delayed_work(&bq->iilimit_setup_work,
> +	} else if (!old_state.power_good) {
> +		dev_dbg(bq->dev, "Power inserted\n");
> +		if (bq->iilimit_autoset_enable)
iilimit_autoset_enable is introduced in patch 6. If we ever need to
bisect this code, this patch will fail to build.

> +			/* configure input current limit */
> +			schedule_delayed_work(&bq->iilimit_setup_work,
>  				      msecs_to_jiffies(BQ24257_ILIM_SET_DELAY));
> +	} else if (new_state->fault == FAULT_NO_BAT) {
> +		dev_warn(bq->dev, "Battery removed\n");
> +	} else if (new_state->fault == FAULT_TIMER) {
> +		dev_err(bq->dev, "Safety timer expired! Battery dead?\n");
>  	}
>  
>  	return;

laurentiu
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html