From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH v4 3/5] ARM: mediatek: add smp bringup code Date: Sat, 26 Sep 2015 10:38:35 +0100 Message-ID: <20150926093835.GA20255@n2100.arm.linux.org.uk> References: <1443109140-5406-1-git-send-email-yingjoe.chen@mediatek.com> <1443109140-5406-4-git-send-email-yingjoe.chen@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1443109140-5406-4-git-send-email-yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Yingjoe Chen Cc: Matthias Brugger , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Arnd Bergmann , Stephen Boyd , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Sascha Hauer , Olof Johansson , srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Thu, Sep 24, 2015 at 11:38:58PM +0800, Yingjoe Chen wrote: > +struct mtk_smp_boot_info { > + unsigned long smp_base; ... > +static const struct mtk_smp_boot_info mtk_mt8135_tz_boot = { > + 0x80002000, 0x3fc, ... > +static const struct mtk_smp_boot_info mtk_mt6589_boot = { > + 0x10002000, 0x34, ... > + if (trustzone) { > + /* smp_base(trustzone-bootinfo) is reserved by device tree */ > + mtk_smp_base = phys_to_virt(mtk_smp_info->smp_base); I can't say whether this is correct or not, as we've got rid of most of the information that would allow me to make that decision. The address passed to phys_to_virt() _must_ be one which is mapped by the kernel as lowmem. I've no idea if the above would fall into that category though. -- FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html