Re: Re: [PATCH 2/6] ARM: dts: sun7i: Enable USB DRC on Bananapi

[Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]

Hi,

On Tue, Sep 29, 2015 at 10:26:37AM +0200, Hans de Goede wrote:
> Hi,
> 
> On 29-09-15 10:04, Maxime Ripard wrote:
> >On Tue, Sep 22, 2015 at 03:36:01PM +0200, Hans de Goede wrote:
> >>Enable the otg/drc usb controller on the Bananapi.
> >>
> >>Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> >
> >Applied all the other patches but this one.
> 
> Thanks, seems you did not push this to your git.kernel.org repo though ?

I think I did, but maybe not at the time you sent the mail.

> >Since we dropped the patch adding the regulators support on the
> >Bananapi until we figure out why the board crash, it doesn't compile
> >anymore.
> 
> How about me doing a v2 of the regulators patch which removes the
> 
> &cpu0 {
>         cpu-supply = <&reg_dcdc2>;
> };
> 
> So that we do not get cpu voltage scaling, then the regulator
> changes should be a NOP, everything should just keep the u-boot
> set voltages, and we can enable oth support.
> 
> And then when we've figured out a safe way to enable cpu voltage
> scaling we can do so with a follow up patch ?
> 
> Is that a plan ? If so say yes and I'll do a v2 of these patches :)

Yep, it sounds like a good plan :)

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com