From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: [PATCH] ARM: shmobile: porter: add SDHI0/2 DT support Date: Thu, 8 Oct 2015 20:08:31 +0900 Message-ID: <20151008110831.GC4961@verge.net.au> References: <2228837.DO5U5OvRSi@wasted.cogentembedded.com> <20151007033957.GA30650@verge.net.au> <5614FBB3.5060806@cogentembedded.com> <20151008021247.GD8756@verge.net.au> <56164B48.6050300@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <56164B48.6050300@cogentembedded.com> Sender: linux-sh-owner@vger.kernel.org To: Sergei Shtylyov Cc: linux-sh@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, magnus.damm@gmail.com, linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Thu, Oct 08, 2015 at 01:54:00PM +0300, Sergei Shtylyov wrote: > Hello. > > On 10/8/2015 5:12 AM, Simon Horman wrote: > > >>>>Define the Porter board dependent part of the SDHI0/2 device nodes along with > >>>>the necessary voltage regulators (note that the Vcc regulators are dummy -- > >>>>they are required but don't actually exist on the board). Also, GPIOs have to > >>>>be used for the CD and WP signals due to the SDHI driver constraints... > >>>> > >>>>This patch is analogous to the commit 1299df03d719 (ARM: shmobile: henninger: > >>>>add SDHI0/2 DT support) as there are no differences between those boards in > >>>>this respect. > >>>> > >>>>Signed-off-by: Sergei Shtylyov > >>>> > >>>>--- > >>>>This patch is against the 'renesas-devel-20151006-v4.3-rc4' tag of Simon > >>>>Horman's 'renesas.git' repo. > >>> > >>>Thanks I have queued this up after addressing some issues > >>>in the changelog that checkpatch complained about: > >>> > >>>* text > 75 characters wide > >>>* Missing '"' around name of patch referred to > >>> > >>>Its looking like there is already quite a log shared between > >> > >> Lot? > >> > >>>r8a7791-porter.dts and r8a7791-henninger.dts. Do you have any > >>>thoughts on consolidating or sharing common elements between > >>>them somehow? > >> > >> I'm still planning to remove the Henninger's .dts for good. It was never > >>sold and so had no users outside Renesas (and Cogent Embedded), I was told. > > > >Thanks, that sounds like a good plan to me. > >Do you have any thoughts on when? > > Well, I was going to reach the feature parity between these 2 boards, > i.e. to support all devices on Porter that are supported on Henninger... THanks, that sounds like an entirely reasonable plan to me.