From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH 09/10] clk: ns2: add clock support for Broadcom Northstar 2 SoC Date: Fri, 9 Oct 2015 17:19:15 -0700 Message-ID: <20151010001915.GY26883@codeaurora.org> References: <1443826665-17570-1-git-send-email-jonmason@broadcom.com> <1443826665-17570-10-git-send-email-jonmason@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1443826665-17570-10-git-send-email-jonmason@broadcom.com> Sender: linux-kernel-owner@vger.kernel.org To: Jon Mason Cc: Michael Turquette , Florian Fainelli , Hauke Mehrtens , Ray Jui , Scott Branden , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com List-Id: devicetree@vger.kernel.org On 10/02, Jon Mason wrote: > diff --git a/drivers/clk/bcm/clk-ns2.c b/drivers/clk/bcm/clk-ns2.c > new file mode 100644 > index 0000000..1d08281 > --- /dev/null > +++ b/drivers/clk/bcm/clk-ns2.c > @@ -0,0 +1,290 @@ > +/* > + * Copyright (C) 2015 Broadcom Corporation > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation version 2. > + * > + * This program is distributed "as is" WITHOUT ANY WARRANTY of any > + * kind, whether express or implied; without even the implied warranty > + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include clkdev looks unused here too? > +#include > +#include And this one? > + > +#include > +#include "clk-iproc.h" > + > +#define reg_val(o, s, w) { .offset = o, .shift = s, .width = w, } I guess we missed this one already, but this isn't a macro resembling a function. Kernel style is to capitalize this sort of macro. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project