devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linux-sh@vger.kernel.org, devicetree@vger.kernel.org,
	robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	magnus.damm@gmail.com, linux@arm.linux.org.uk,
	linux-arm-kernel@lists.infradead.org,
	Geert Uytterhoeven <geert@glider.be>
Subject: Re: [PATCH] ARM: shmobile: porter: add QSPI DT support
Date: Mon, 12 Oct 2015 09:19:20 +0900	[thread overview]
Message-ID: <20151012001920.GG20025@verge.net.au> (raw)
In-Reply-To: <20151012000453.GC20025@verge.net.au>

On Mon, Oct 12, 2015 at 09:04:53AM +0900, Simon Horman wrote:
> [Cc Geert]
> 
> On Fri, Oct 09, 2015 at 11:51:05PM +0300, Sergei Shtylyov wrote:
> > Define the Porter board dependent part of the QSPI device node.
> > Add device nodes  for Spansion  S25FL512S SPI flash and the MTD partitions
> > on it.
> > 
> > This patch is  mostly analogous to the commit f59838d44835 (ARM: shmobile:
> > henninger: add QSPI DT support) as there  are no differences between the
> > boards in this respect.
> > 
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> Thanks, I have queued this up for v4.4.

For the record, I queued-up v2.

> 
> > ---
> > This patch is against 'renesas-devel-20151008-v4.3-rc4' tag of Simon Horman's
> > 'renesas.git' repo plus the Porter I2C2 and VIN0/ADV7180 patches posted earlier.
> > 
> >  arch/arm/boot/dts/r8a7791-porter.dts |   38 +++++++++++++++++++++++++++++++++++
> >  1 file changed, 38 insertions(+)
> > 
> > Index: renesas/arch/arm/boot/dts/r8a7791-porter.dts
> > ===================================================================
> > --- renesas.orig/arch/arm/boot/dts/r8a7791-porter.dts
> > +++ renesas/arch/arm/boot/dts/r8a7791-porter.dts
> > @@ -110,6 +110,11 @@
> >  		renesas,function = "sdhi2";
> >  	};
> >  
> > +	qspi_pins: spi0 {
> > +		renesas,groups = "qspi_ctrl", "qspi_data4";
> > +		renesas,function = "qspi";
> > +	};
> > +
> >  	i2c2_pins: i2c2 {
> >  		renesas,groups = "i2c2";
> >  		renesas,function = "i2c2";
> > @@ -165,6 +170,39 @@
> >  	status = "okay";
> >  };
> >  
> > +&qspi {
> > +	pinctrl-0 = <&qspi_pins>;
> > +	pinctrl-names = "default";
> > +
> > +	status = "okay";
> > +
> > +	flash@0 {
> > +		#address-cells = <1>;
> > +		#size-cells = <1>;
> > +		compatible = "spansion,s25fl512s", "jedec,spi-nor";
> 
> spansion,s25fl512s is used in several dt files but it seems to be
> undocumented. Do we have a plan to resolve this?
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

  reply	other threads:[~2015-10-12  0:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-09 20:51 [PATCH] ARM: shmobile: porter: add QSPI DT support Sergei Shtylyov
2015-10-12  0:04 ` Simon Horman
2015-10-12  0:19   ` Simon Horman [this message]
2015-10-12  6:53   ` Geert Uytterhoeven
2015-10-13  1:04     ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151012001920.GG20025@verge.net.au \
    --to=horms@verge.net.au \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=geert@glider.be \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=magnus.damm@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).