devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
	Mark Brown <broonie@kernel.org>,
	robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	myungjoo.ham@samsung.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH v2 4/5] mfd: arizona: Update DT binding documentation for mic detection
Date: Tue, 13 Oct 2015 16:23:31 +0100	[thread overview]
Message-ID: <20151013152331.GL8805@ck-lbox> (raw)
In-Reply-To: <20151013141822.GC32409@x1>

On Tue, Oct 13, 2015 at 03:18:22PM +0100, Lee Jones wrote:
> On Tue, 13 Oct 2015, Chanwoo Choi wrote:
> > On 2015년 10월 13일 22:59, Chanwoo Choi wrote:
> > > On 2015년 10월 13일 22:50, Lee Jones wrote:
> > >> On Tue, 13 Oct 2015, Charles Keepax wrote:
> > >>
> > >>> On Tue, Oct 13, 2015 at 09:02:18AM +0100, Lee Jones wrote:
> > >>>> On Mon, 12 Oct 2015, Mark Brown wrote:
> > >>>>
> > >>>>> On Mon, Oct 12, 2015 at 09:45:54AM +0100, Charles Keepax wrote:
> > >>>>>> On Wed, Oct 07, 2015 at 01:26:42PM +0100, Lee Jones wrote:
> > >>>>>>> On Wed, 07 Oct 2015, Mark Brown wrote:
> > >> Now I know that jack detection is an Extcon thing and Extcon Ack will
> > >> do just nicely.  However, that begs the question; if they are an
> > >> Extcon thing, why aren't they in the Extcon binding document?
> > > 
> > > As I knew, the arizona-extcon is one device of the MFD devices 
> > > for WMxxxx series in the driver/mfd/arizona-core.c. So, If arizona-extcon
> > > driver needs the some property for dt support, some property should be
> > > included in MFD device tree node. There is no separate device tree node for
> > > arizona-extcon driver.
> > 
> > If creating the separate extcon doc for extcon-arizona.c driver, it is possible
> > to make the child device tree node which is located at the below of arizona MFD
> > device tree node.
> > 
> > I agree about Lee's opinion to make the separate the Extcon doc for extcon-arizona.c.
> 
> This is how we normally document MFDs.  Extcon doesn't even need to
> have it's own child-node (it can if you want though -- it's however
> you want to represent it), you can just put something like this in the
> MFD binding doc:
> 
> Optional properties
> this		: Does this
> that		: Does that
> 
> Also any child device specific property:
> 	GPIO    See: ../extcon/arizona.txt
> 	Extcon  See: ../gpio/arizona.txt
> 
> Etc.  Or words to that effect.  See some other MFDs for examples.

More accident of history than anything else I will send a patch
to split the binding up into the seperate subsystems shortly.

Thanks,
Charles

  reply	other threads:[~2015-10-13 15:23 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-02 16:29 [PATCH v2 0/5] Arizona Extcon Update Device Bindings Charles Keepax
     [not found] ` <1443803363-3251-1-git-send-email-ckeepax-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2015-10-02 16:29   ` [PATCH v2 1/5] extcon: arizona: Add device binding to enable ADC mode micdet Charles Keepax
2015-10-02 16:29 ` [PATCH v2 2/5] extcon: arizona: Add device binding for the general purpose switch Charles Keepax
2015-10-02 16:29 ` [PATCH v2 3/5] extcon: arizona: Add device binding for jack detect polarity inversion Charles Keepax
2015-10-02 16:29 ` [PATCH v2 4/5] mfd: arizona: Update DT binding documentation for mic detection Charles Keepax
2015-10-05 10:02   ` Lee Jones
2015-10-07 10:00   ` Mark Brown
     [not found]     ` <20151007100017.GB12635-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-10-07 12:26       ` Lee Jones
2015-10-12  8:45         ` Charles Keepax
2015-10-12 10:16           ` Chanwoo Choi
2015-10-12 10:25             ` Chanwoo Choi
2015-10-13  8:03               ` Lee Jones
2015-10-13 10:11                 ` Chanwoo Choi
2015-10-12 13:43           ` Mark Brown
     [not found]             ` <20151012134309.GE1542-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-10-13  8:02               ` Lee Jones
2015-10-13 12:14                 ` Charles Keepax
2015-10-13 13:50                   ` Lee Jones
2015-10-13 13:59                     ` Chanwoo Choi
     [not found]                       ` <561D0E4C.4010205-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-10-13 14:09                         ` Chanwoo Choi
2015-10-13 14:18                           ` Lee Jones
2015-10-13 15:23                             ` Charles Keepax [this message]
2015-10-13 15:12                 ` Mark Brown
2015-10-14  7:28                   ` Lee Jones
2015-10-14  9:49                     ` Mark Brown
     [not found]                       ` <20151014094903.GP14956-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-10-14 12:30                         ` Lee Jones
2015-10-14 13:09                           ` Mark Brown
2015-10-14 13:20                             ` Lee Jones
2015-10-13  8:08   ` Lee Jones
2015-10-13 12:15     ` Charles Keepax
2015-10-13 13:43       ` Lee Jones
2015-10-02 16:29 ` [PATCH v2 5/5] mfd: arizona: Update DT binding document for jack detection invert Charles Keepax
2015-10-05 10:01   ` Lee Jones
2015-10-12  8:15     ` Charles Keepax
2015-10-13  8:07       ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151013152331.GL8805@ck-lbox \
    --to=ckeepax@opensource.wolfsonmicro.com \
    --cc=broonie@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=myungjoo.ham@samsung.com \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).