From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Norris Subject: Re: [PATCH v2 2/4] mtd: nand: Allow MTD_NAND_BRCMNAND to be selected for ARM64 Date: Fri, 16 Oct 2015 09:54:45 -0700 Message-ID: <20151016165445.GG108923@google.com> References: <1444986537-28387-1-git-send-email-anup.patel@broadcom.com> <1444986537-28387-3-git-send-email-anup.patel@broadcom.com> <5673177.0QYFhMPCBq@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <5673177.0QYFhMPCBq@wuerfel> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Anup Patel , David Woodhouse , linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Florian Fainelli , Scott Branden , Pawel Moll , Ian Campbell , Catalin Marinas , Will Deacon , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ray Jui , Vikram Prakash , Rob Herring , bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org, Sandeep Tripathy , Kumar Gala , Pramod KUMAR List-Id: devicetree@vger.kernel.org On Fri, Oct 16, 2015 at 06:24:21PM +0200, Arnd Bergmann wrote: > I think you also need this one: Are you sure? > 8<----------- > From 0ab7b2d32921b3f3da15274d8c3982ba1d54660f Mon Sep 17 00:00:00 2001 > From: Arnd Bergmann > Date: Thu, 4 Jun 2015 09:25:59 +0200 > Subject: [PATCH] mtd: brcmnand depends on MTD_NAND > > MTD_NAND_BRCMNAND uses the generic nand functions, but is currently allowed > to be built without CONFIG_MTD_NAND, which results in a link error: > > drivers/built-in.o: In function `brcmnand_remove': > coresight-replicator.c:(.text+0x17ae6c): undefined reference to `nand_release' > drivers/built-in.o: In function `brcmnand_probe': > coresight-replicator.c:(.text+0x17d4b4): undefined reference to `nand_scan_ident' > coresight-replicator.c:(.text+0x17d948): undefined reference to `nand_scan_tail' How did you get this? MTD_NAND_BRCMNAND is surrounded in the 'if MTD_NAND' block, which implicitly generates a MTD_NAND dependency. And I can confirm that in menuconfig, I see this when I disable MTD_NAND and search for BRCMNAND: Symbol: MTD_NAND_BRCMNAND [=n] Type : tristate Prompt: Broadcom STB NAND controller Location: -> Device Drivers -> Memory Technology Device (MTD) support (MTD [=y]) (1) -> NAND Device Support (MTD_NAND [=n]) Defined at drivers/mtd/nand/Kconfig:394 Depends on: MTD [=y] && MTD_NAND [=n] && (ARM [=y] || ARM64 || MIPS) Brian > This adds an explicit Kconfig dependency. > > Signed-off-by: Arnd Bergmann > > diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig > index 289664089cf3..4b7e853ce35d 100644 > --- a/drivers/mtd/nand/Kconfig > +++ b/drivers/mtd/nand/Kconfig > @@ -393,6 +393,7 @@ config MTD_NAND_GPMI_NAND > > config MTD_NAND_BRCMNAND > tristate "Broadcom STB NAND controller" > + depends on MTD_NAND > depends on ARM || ARM64 || MIPS > help > Enables the Broadcom NAND controller driver. The controller was > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html