From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 1/4] Documentation: tps65086: Add DT bindings for the TPS65086 PMIC Date: Mon, 19 Oct 2015 16:21:00 +0100 Message-ID: <20151019152100.GK31804@x1> References: <1445014753-15450-1-git-send-email-afd@ti.com> <1445014753-15450-2-git-send-email-afd@ti.com> <20151019091311.GH31804@x1> <5625095F.5080204@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <5625095F.5080204@ti.com> Sender: linux-gpio-owner@vger.kernel.org To: "Andrew F. Davis" Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Mark Brown , Alexandre Courbot , Grygorii Strashko , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org On Mon, 19 Oct 2015, Andrew F. Davis wrote: > On 10/19/2015 04:13 AM, Lee Jones wrote: > >On Fri, 16 Oct 2015, Andrew F. Davis wrote: > > > >>The TPS65086 PMIC contains several regulators and a GPO controller. > >>Add bindings for the TPS65086 PMIC. > >> > >>Signed-off-by: Andrew F. Davis > >>--- > >> .../devicetree/bindings/gpio/gpio-tps65086.txt | 17 ++++++++ > >> Documentation/devicetree/bindings/mfd/tps65086.txt | 46 +++++++++= +++++++++++++ > >> .../bindings/regulator/tps65086-regulator.txt | 36 +++++++++= ++++++++ > > > >Please split these up into separate patches. > > > >There is no functional reason to bundle them up. > > >=20 > ACK >=20 > >> 3 files changed, 99 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-tp= s65086.txt > >> create mode 100644 Documentation/devicetree/bindings/mfd/tps65086= =2Etxt > >> create mode 100644 Documentation/devicetree/bindings/regulator/tp= s65086-regulator.txt > > > >[...] > > > >>diff --git a/Documentation/devicetree/bindings/mfd/tps65086.txt b/D= ocumentation/devicetree/bindings/mfd/tps65086.txt > >>new file mode 100644 > >>index 0000000..4b6aeb4 > >>--- /dev/null > >>+++ b/Documentation/devicetree/bindings/mfd/tps65086.txt > >>@@ -0,0 +1,46 @@ > >>+* TPS65086 Power Management Integrated Circuit bindings > >>+ > >>+Required properties: > >>+ - compatible : Should be "ti,tps65086". > > > >Any indication that it's a PMIC? > > >=20 > In the compatible string? Ya. > >>+ - reg : Slave address. > > > >I2C/SPI? > > >=20 > ACK >=20 > >>+ - interrupt-parent : The parent interrupt controller. > > > >Phandled to ... > > >=20 > ACK >=20 > >>+ - interrupts : The interrupt line the device is connected to. > >>+ - interrupt-controller : Marks the device node as an interrupt co= ntroller. > >>+ - #interrupt-cells : The number of cells to describe an IRQ, this > >>+ should be 2. The first cell is the IRQ number. > >>+ The second cell is the flags, encoded as the trigger > >>+ masks from ../interrupt-controller/interrupts.txt. > > > >Masks? What masks? > > > >Best to make a link to the header where the flags are defined here. > > >=20 > ACK >=20 > >>+Additional nodes defined in: > >>+ - Regulators : ../regulator/tps65086-regulator.txt. > >>+ - GPIO : ../gpio/gpio-tps65086.txt. > > > >I'd suggest removing the full stops from all of the lines above. > > > >Just treat them as bullet points like we normally do. > > >=20 > ACK >=20 > >>+Example: > >>+ > >>+ pmic: tps65086@5e { > >>+ compatible =3D "ti,tps65086"; > >>+ reg =3D <0x5e>; > >>+ interrupt-parent =3D <&gpio1>; > >>+ interrupts =3D <28 IRQ_TYPE_LEVEL_LOW>; > >>+ interrupt-controller; > >>+ #interrupt-cells =3D <2>; > >>+ > >>+ regulators { > >>+ compatible =3D "ti,tps65086-regulator"; > >>+ > >>+ buck1 { > >>+ regulator-name =3D "vcc1"; > >>+ regulator-min-microvolt =3D <1600000>; > >>+ regulator-max-microvolt =3D <1600000>; > >>+ regulator-boot-on; > >>+ ti,regulator-decay; > >>+ ti,regulator-step-size-25mv; > >>+ }; > >>+ }; > >>+ > >>+ gpio4: tps65086_gpio { > >>+ compatible =3D "ti,tps65086-gpio"; > >>+ gpio-controller; > >>+ #gpio-cells =3D <2>; > >>+ }; > >>+ }; > > > >[...] > > >=20 --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html