devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Turquette <mturquette@baylibre.com>
To: Inki Dae <inki.dae@samsung.com>
Cc: Andrzej Hajda <a.hajda@samsung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
	Kukjin Kim <kgene@kernel.org>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Hyungwon Hwang <human.hwang@samsung.com>
Subject: Re: [PATCH 01/10] clk/samsung: exynos5433: add definitions of HDMI-PHY output clocks
Date: Tue, 20 Oct 2015 03:34:16 -0700	[thread overview]
Message-ID: <20151020103416.20687.40409@quantum> (raw)
In-Reply-To: <1445332961-25419-2-git-send-email-a.hajda@samsung.com>

Quoting Andrzej Hajda (2015-10-20 02:22:32)
> HDMI driver must re-parent respective muxes during HDMI-PHY on/off
> to HDMI-PHY output clocks. To reference those clocks their
> definitions should be added.
> 
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
>  drivers/clk/samsung/clk-exynos5433.c   | 6 ++++--
>  include/dt-bindings/clock/exynos5433.h | 5 ++++-
>  2 files changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c
> index 650ec13..e037406 100644
> --- a/drivers/clk/samsung/clk-exynos5433.c
> +++ b/drivers/clk/samsung/clk-exynos5433.c
> @@ -2614,8 +2614,10 @@ static struct samsung_fixed_rate_clock disp_fixed_clks[] __initdata = {
>         FRATE(0, "phyclk_mipidphy0_rxclkesc0_phy", NULL, CLK_IS_ROOT,
>                         100000000),
>         /* PHY clocks from HDMI_PHY */
> -       FRATE(0, "phyclk_hdmiphy_tmds_clko_phy", NULL, CLK_IS_ROOT, 300000000),
> -       FRATE(0, "phyclk_hdmiphy_pixel_clko_phy", NULL, CLK_IS_ROOT, 166000000),
> +       FRATE(CLK_PHYCLK_HDMIPHY_TMDS_CLKO_PHY, "phyclk_hdmiphy_tmds_clko_phy",
> +                       NULL, CLK_IS_ROOT, 300000000),
> +       FRATE(CLK_PHYCLK_HDMIPHY_PIXEL_CLKO_PHY, "phyclk_hdmiphy_pixel_clko_phy",
> +                       NULL, CLK_IS_ROOT, 166000000),
>  };
>  
>  static struct samsung_mux_clock disp_mux_clks[] __initdata = {
> diff --git a/include/dt-bindings/clock/exynos5433.h b/include/dt-bindings/clock/exynos5433.h
> index 5bd80d5..4f0d566 100644
> --- a/include/dt-bindings/clock/exynos5433.h
> +++ b/include/dt-bindings/clock/exynos5433.h
> @@ -765,7 +765,10 @@
>  #define CLK_SCLK_RGB_VCLK                              109
>  #define CLK_SCLK_RGB_TV_VCLK                           110
>  
> -#define DISP_NR_CLK                                    111
> +#define CLK_PHYCLK_HDMIPHY_PIXEL_CLKO_PHY              111
> +#define CLK_PHYCLK_HDMIPHY_TMDS_CLKO_PHY               112
> +
> +#define DISP_NR_CLK                                    113

Why break compatibility with older DTBs?

Regards,
Mike

>  
>  /* CMU_AUD */
>  #define CLK_MOUT_AUD_PLL_USER                          1
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-clk" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-10-20 10:34 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-20  9:22 [PATCH 00/10] drm/exynos/decon5433: add support to DECON-TV Andrzej Hajda
2015-10-20  9:22 ` [PATCH 01/10] clk/samsung: exynos5433: add definitions of HDMI-PHY output clocks Andrzej Hajda
2015-10-20 10:34   ` Michael Turquette [this message]
2015-10-20 10:40     ` Marek Szyprowski
2015-10-20 11:17     ` Sylwester Nawrocki
2015-10-21  8:59       ` Michael Turquette
2015-10-20  9:22 ` [PATCH 02/10] clk/samsung: exynos5433: add pclk_decon clock Andrzej Hajda
2015-10-20 12:19   ` Krzysztof Kozlowski
2015-10-20  9:22 ` [PATCH 03/10] drm/exynos/decon5433: add PCLK clock Andrzej Hajda
2015-10-20  9:22 ` [PATCH 04/10] dt-bindings: video: add PCLK clock entry to exynos5433-decon Andrzej Hajda
2015-10-20 12:24   ` Krzysztof Kozlowski
2015-10-20 12:41     ` Andrzej Hajda
2015-10-20 12:48       ` Krzysztof Kozlowski
2015-10-20 12:50     ` Sylwester Nawrocki
2015-10-20  9:22 ` [PATCH 05/10] drm/exynos/decon5433: fix timing registers writes Andrzej Hajda
2015-10-20  9:22 ` [PATCH 06/10] drm/exynos/decon5433: add function to set particular register bits Andrzej Hajda
2015-10-20  9:22 ` [PATCH 07/10] drm/exynos/decon5433: merge different flag fields Andrzej Hajda
2015-10-20  9:22 ` [PATCH 08/10] drm/exynos/decon5433: remove duplicated initialization Andrzej Hajda
2015-10-20  9:22 ` [PATCH 09/10] dt-bindings: video: exynos5433-decon: add bindings for DECON-TV Andrzej Hajda
2015-10-20 12:30   ` Krzysztof Kozlowski
2015-10-20 12:53     ` Andrzej Hajda
2015-10-20 12:55       ` Krzysztof Kozlowski
2015-10-26 11:59         ` [PATCH v2 " Andrzej Hajda
2015-10-28  1:06           ` Krzysztof Kozlowski
     [not found]           ` <1445860796-23045-1-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-11-13 14:46             ` Rob Herring
2016-01-14 10:36           ` Andrzej Hajda
2016-01-14 10:49             ` Inki Dae
2016-01-17 23:45               ` Krzysztof Kozlowski
2016-01-18  9:54                 ` Inki Dae
2016-01-18 10:12                   ` Andrzej Hajda
2016-01-19  6:34                     ` Inki Dae
2015-10-20  9:22 ` [PATCH 10/10] drm/exynos/decon5433: add support " Andrzej Hajda
2015-10-23 11:55   ` Inki Dae
2015-10-23 13:03     ` Andrzej Hajda
     [not found]       ` <562A300F.2000108-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-10-23 15:05         ` Inki Dae
2015-10-20 12:20 ` [PATCH 00/10] drm/exynos/decon5433: add support to DECON-TV Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151020103416.20687.40409@quantum \
    --to=mturquette@baylibre.com \
    --cc=a.hajda@samsung.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=human.hwang@samsung.com \
    --cc=inki.dae@samsung.com \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=s.nawrocki@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).