[PATCH v2 1/3] dt-bindings: Consolidate SRAM bindings from all vendors

[PATCH v2 1/3] dt-bindings: Consolidate SRAM bindings from all vendors

[Krzysztof Kozlowski]

SRAM bindings for various SoCs, using the mmio-sram genalloc
API, are spread over different places - per SoC vendor. Since all of
these are quite similar (they depend on mmio-sram) move them to a common
place.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
Cc: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
Cc: Kukjin Kim <kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Suggested-by: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

---

Changes since v1:
1. New patch. Extended suggestion from Rob.
---
 .../bindings/{arm/rockchip/pmu-sram.txt => sram/rockchip-pmu-sram.txt}    | 0
 .../bindings/{arm/rockchip/smp-sram.txt => sram/rockchip-smp-sram.txt}    | 0
 .../bindings/{arm/exynos/smp-sysram.txt => sram/samsung-sram.txt}         | 0
 Documentation/devicetree/bindings/{misc => sram}/sram.txt                 | 0
 .../devicetree/bindings/{soc/sunxi/sram.txt => sram/sunxi-sram.txt}       | 0
 5 files changed, 0 insertions(+), 0 deletions(-)
 rename Documentation/devicetree/bindings/{arm/rockchip/pmu-sram.txt => sram/rockchip-pmu-sram.txt} (100%)
 rename Documentation/devicetree/bindings/{arm/rockchip/smp-sram.txt => sram/rockchip-smp-sram.txt} (100%)
 rename Documentation/devicetree/bindings/{arm/exynos/smp-sysram.txt => sram/samsung-sram.txt} (100%)
 rename Documentation/devicetree/bindings/{misc => sram}/sram.txt (100%)
 rename Documentation/devicetree/bindings/{soc/sunxi/sram.txt => sram/sunxi-sram.txt} (100%)

diff --git a/Documentation/devicetree/bindings/arm/rockchip/pmu-sram.txt b/Documentation/devicetree/bindings/sram/rockchip-pmu-sram.txt
similarity index 100%
rename from Documentation/devicetree/bindings/arm/rockchip/pmu-sram.txt
rename to Documentation/devicetree/bindings/sram/rockchip-pmu-sram.txt
diff --git a/Documentation/devicetree/bindings/arm/rockchip/smp-sram.txt b/Documentation/devicetree/bindings/sram/rockchip-smp-sram.txt
similarity index 100%
rename from Documentation/devicetree/bindings/arm/rockchip/smp-sram.txt
rename to Documentation/devicetree/bindings/sram/rockchip-smp-sram.txt
diff --git a/Documentation/devicetree/bindings/arm/exynos/smp-sysram.txt b/Documentation/devicetree/bindings/sram/samsung-sram.txt
similarity index 100%
rename from Documentation/devicetree/bindings/arm/exynos/smp-sysram.txt
rename to Documentation/devicetree/bindings/sram/samsung-sram.txt
diff --git a/Documentation/devicetree/bindings/misc/sram.txt b/Documentation/devicetree/bindings/sram/sram.txt
similarity index 100%
rename from Documentation/devicetree/bindings/misc/sram.txt
rename to Documentation/devicetree/bindings/sram/sram.txt
diff --git a/Documentation/devicetree/bindings/soc/sunxi/sram.txt b/Documentation/devicetree/bindings/sram/sunxi-sram.txt
similarity index 100%
rename from Documentation/devicetree/bindings/soc/sunxi/sram.txt
rename to Documentation/devicetree/bindings/sram/sunxi-sram.txt
-- 
1.9.1

[PATCH v2 2/3] dt-bindings: Consolidate Exynos SoC bindings

[Krzysztof Kozlowski]

Exynos SoC Device Tree bindings are spread over arm/exynos/ and
arm/samsung/ directories. There is no need for that separation and it
actually confuses. Put power domain bindings under power/ and
remaining samsung-boards.txt under arm/samsung/.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Kukjin Kim <kgene@kernel.org>
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

---

Changes since v1:
1. Move power_domain.txt to power/pd-samsung.txt.
2. The smp-sysram.txt is moved in previous patch to sram/ directory
   (Suggested by Rob Herring).
3. Added Javier's reviewed-by. Although there are some differences since
   v1 but this is merely re-organization. Please let me know if the
   review tag is no longer valid.
---
 Documentation/devicetree/bindings/arm/{ => samsung}/samsung-boards.txt    | 0
 .../bindings/{arm/exynos/power_domain.txt => power/pd-samsung.txt}        | 0
 2 files changed, 0 insertions(+), 0 deletions(-)
 rename Documentation/devicetree/bindings/arm/{ => samsung}/samsung-boards.txt (100%)
 rename Documentation/devicetree/bindings/{arm/exynos/power_domain.txt => power/pd-samsung.txt} (100%)

diff --git a/Documentation/devicetree/bindings/arm/samsung-boards.txt b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
similarity index 100%
rename from Documentation/devicetree/bindings/arm/samsung-boards.txt
rename to Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
diff --git a/Documentation/devicetree/bindings/arm/exynos/power_domain.txt b/Documentation/devicetree/bindings/power/pd-samsung.txt
similarity index 100%
rename from Documentation/devicetree/bindings/arm/exynos/power_domain.txt
rename to Documentation/devicetree/bindings/power/pd-samsung.txt
-- 
1.9.1

[PATCH v2 3/3] dt-bindings: EXYNOS: Document compatibles from other vendors

[Krzysztof Kozlowski]

Document compatibles used on other Exynos-based boards (non-Samsung):
FriendlyARM, Google, Hardkernel and Insignal.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Kukjin Kim <kgene@kernel.org>
Cc: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: Hakjoo Kim <ruppi.kim@hardkernel.com>
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

---

Changes since v1:
1. Added Javier's reviewed-by
---
 .../bindings/arm/samsung/samsung-boards.txt        | 44 +++++++++++++++++++++-
 1 file changed, 43 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
index 43589d2466a7..da078702ae73 100644
--- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
+++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
@@ -16,7 +16,49 @@ Required root node properties:
 	- "samsung,sd5v1"	- for Exynos5440-based Samsung board.
 	- "samsung,ssdk5440"	- for Exynos5440-based Samsung board.
 
-Optional:
+* Other companies Exynos SoC based
+  * FriendlyARM
+        - "friendlyarm,tiny4412"  - for Exynos4412-based FriendlyARM
+                                    TINY4412 board.
+
+  * Google
+        - "google,pi"             - for Exynos5800-based Google Peach Pi
+                                    Rev 10+ board,
+          also: "google,pi-rev16", "google,pi-rev15", "google,pi-rev14",
+		"google,pi-rev13", "google,pi-rev12", "google,pi-rev11",
+                "google,pi-rev10", "google,peach".
+
+        - "google,pit"            - for Exynos5420-based Google Peach Pit
+                                    Rev 6+ (Exynos5420),
+          also: "google,pit-rev16", "google,pit-rev15", "google,pit-rev14",
+                "google,pit-rev13", "google,pit-rev12", "google,pit-rev11",
+                "google,pit-rev10", "google,pit-rev9", "google,pit-rev8",
+                "google,pit-rev7", "google,pit-rev6", "google,peach".
+
+        - "google,snow-rev4"      - for Exynos5250-based Google Snow board,
+          also: "google,snow"
+        - "google,snow-rev5"      - for Exynos5250-based Google Snow
+                                    Rev 5+ board.
+        - "google,spring"         - for Exynos5250-based Google Spring board.
+
+  * Hardkernel
+        - "hardkernel,odroid-u3"  - for Exynos4412-based Hardkernel Odroid U3.
+        - "hardkernel,odroid-x"   - for Exynos4412-based Hardkernel Odroid X.
+        - "hardkernel,odroid-x2"  - for Exynos4412-based Hardkernel Odroid X2.
+        - "hardkernel,odroid-xu3" - for Exynos5422-based Hardkernel Odroid XU3.
+        - "hardkernel,odroid-xu3-lite" - for Exynos5422-based Hardkernel
+                                         Odroid XU3 Lite board.
+        - "hardkernel,odroid-xu4" - for Exynos5422-based Hardkernel Odroid XU4.
+
+  * Insignal
+        - "insignal,arndale"      - for Exynos5250-based Insignal Arndale board.
+        - "insignal,arndale-octa" - for Exynos5420-based Insignal Arndale
+                                    Octa board.
+        - "insignal,origen"       - for Exynos4210-based Insignal Origen board.
+        - "insignal,origen4412    - for Exynos4412-based Insignal Origen board.
+
+
+Optional nodes:
     - firmware node, specifying presence and type of secure firmware:
         - compatible: only "samsung,secure-firmware" is currently supported
         - reg: address of non-secure SYSRAM used for communication with firmware
-- 
1.9.1

Re: [PATCH v2 1/3] dt-bindings: Consolidate SRAM bindings from all vendors

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 2077 bytes --]

Hi,

On Thu, Oct 22, 2015 at 10:25:28AM +0900, Krzysztof Kozlowski wrote:
> SRAM bindings for various SoCs, using the mmio-sram genalloc
> API, are spread over different places - per SoC vendor. Since all of
> these are quite similar (they depend on mmio-sram) move them to a common
> place.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Kukjin Kim <kgene@kernel.org>
> Suggested-by: Rob Herring <robh+dt@kernel.org>
> 
> ---
> 
> Changes since v1:
> 1. New patch. Extended suggestion from Rob.
> ---
>  .../bindings/{arm/rockchip/pmu-sram.txt => sram/rockchip-pmu-sram.txt}    | 0
>  .../bindings/{arm/rockchip/smp-sram.txt => sram/rockchip-smp-sram.txt}    | 0
>  .../bindings/{arm/exynos/smp-sysram.txt => sram/samsung-sram.txt}         | 0
>  Documentation/devicetree/bindings/{misc => sram}/sram.txt                 | 0
>  .../devicetree/bindings/{soc/sunxi/sram.txt => sram/sunxi-sram.txt}       | 0
>  5 files changed, 0 insertions(+), 0 deletions(-)
>  rename Documentation/devicetree/bindings/{arm/rockchip/pmu-sram.txt => sram/rockchip-pmu-sram.txt} (100%)
>  rename Documentation/devicetree/bindings/{arm/rockchip/smp-sram.txt => sram/rockchip-smp-sram.txt} (100%)
>  rename Documentation/devicetree/bindings/{arm/exynos/smp-sysram.txt => sram/samsung-sram.txt} (100%)
>  rename Documentation/devicetree/bindings/{misc => sram}/sram.txt (100%)
>  rename Documentation/devicetree/bindings/{soc/sunxi/sram.txt => sram/sunxi-sram.txt} (100%)

I'm not sure about that one. The SRAM bindins we have for sunxi is for
an SRAM controller, that maps the SRAM either to the CPU or to the
devices.

It's not really related to the other users, and wouldn't it be
confusing to have a driver in drivers/soc, and a Documentation in
another sub-directory?

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH v2 1/3] dt-bindings: Consolidate SRAM bindings from all vendors

[Krzysztof Kozlowski]

On 22.10.2015 18:05, Maxime Ripard wrote:
> Hi,
> 
> On Thu, Oct 22, 2015 at 10:25:28AM +0900, Krzysztof Kozlowski wrote:
>> SRAM bindings for various SoCs, using the mmio-sram genalloc
>> API, are spread over different places - per SoC vendor. Since all of
>> these are quite similar (they depend on mmio-sram) move them to a common
>> place.
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> Cc: Heiko Stuebner <heiko@sntech.de>
>> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
>> Cc: Chen-Yu Tsai <wens@csie.org>
>> Cc: Kukjin Kim <kgene@kernel.org>
>> Suggested-by: Rob Herring <robh+dt@kernel.org>
>>
>> ---
>>
>> Changes since v1:
>> 1. New patch. Extended suggestion from Rob.
>> ---
>>  .../bindings/{arm/rockchip/pmu-sram.txt => sram/rockchip-pmu-sram.txt}    | 0
>>  .../bindings/{arm/rockchip/smp-sram.txt => sram/rockchip-smp-sram.txt}    | 0
>>  .../bindings/{arm/exynos/smp-sysram.txt => sram/samsung-sram.txt}         | 0
>>  Documentation/devicetree/bindings/{misc => sram}/sram.txt                 | 0
>>  .../devicetree/bindings/{soc/sunxi/sram.txt => sram/sunxi-sram.txt}       | 0
>>  5 files changed, 0 insertions(+), 0 deletions(-)
>>  rename Documentation/devicetree/bindings/{arm/rockchip/pmu-sram.txt => sram/rockchip-pmu-sram.txt} (100%)
>>  rename Documentation/devicetree/bindings/{arm/rockchip/smp-sram.txt => sram/rockchip-smp-sram.txt} (100%)
>>  rename Documentation/devicetree/bindings/{arm/exynos/smp-sysram.txt => sram/samsung-sram.txt} (100%)
>>  rename Documentation/devicetree/bindings/{misc => sram}/sram.txt (100%)
>>  rename Documentation/devicetree/bindings/{soc/sunxi/sram.txt => sram/sunxi-sram.txt} (100%)
> 
> I'm not sure about that one. The SRAM bindins we have for sunxi is for
> an SRAM controller, that maps the SRAM either to the CPU or to the
> devices.
> 
> It's not really related to the other users, and wouldn't it be
> confusing to have a driver in drivers/soc, and a Documentation in
> another sub-directory?

I guess the only relation to other users is the "mmio-sram". In the same
time this is still similar to e.g. Samsung's sram bindings (where the
memory is mapped to CPU only).

Being located in drivers/soc is not an issue here - code for other
vendors may be moved there as well in the future.

Of course I do not insist. Actually Rob's comment was only about moving
sram.txt and Samsung's sram to common place.

Anyway I will be sending v3 of these because while looking more
carefully I found hard-coded paths to bindings/misc/sram.txt. I'll fix
it in next version.

Best regards,
Krzysztof

Re: [PATCH v2 1/3] dt-bindings: Consolidate SRAM bindings from all vendors

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 3007 bytes --]

On Thu, Oct 22, 2015 at 06:19:31PM +0900, Krzysztof Kozlowski wrote:
> On 22.10.2015 18:05, Maxime Ripard wrote:
> > Hi,
> > 
> > On Thu, Oct 22, 2015 at 10:25:28AM +0900, Krzysztof Kozlowski wrote:
> >> SRAM bindings for various SoCs, using the mmio-sram genalloc
> >> API, are spread over different places - per SoC vendor. Since all of
> >> these are quite similar (they depend on mmio-sram) move them to a common
> >> place.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> >> Cc: Heiko Stuebner <heiko@sntech.de>
> >> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> >> Cc: Chen-Yu Tsai <wens@csie.org>
> >> Cc: Kukjin Kim <kgene@kernel.org>
> >> Suggested-by: Rob Herring <robh+dt@kernel.org>
> >>
> >> ---
> >>
> >> Changes since v1:
> >> 1. New patch. Extended suggestion from Rob.
> >> ---
> >>  .../bindings/{arm/rockchip/pmu-sram.txt => sram/rockchip-pmu-sram.txt}    | 0
> >>  .../bindings/{arm/rockchip/smp-sram.txt => sram/rockchip-smp-sram.txt}    | 0
> >>  .../bindings/{arm/exynos/smp-sysram.txt => sram/samsung-sram.txt}         | 0
> >>  Documentation/devicetree/bindings/{misc => sram}/sram.txt                 | 0
> >>  .../devicetree/bindings/{soc/sunxi/sram.txt => sram/sunxi-sram.txt}       | 0
> >>  5 files changed, 0 insertions(+), 0 deletions(-)
> >>  rename Documentation/devicetree/bindings/{arm/rockchip/pmu-sram.txt => sram/rockchip-pmu-sram.txt} (100%)
> >>  rename Documentation/devicetree/bindings/{arm/rockchip/smp-sram.txt => sram/rockchip-smp-sram.txt} (100%)
> >>  rename Documentation/devicetree/bindings/{arm/exynos/smp-sysram.txt => sram/samsung-sram.txt} (100%)
> >>  rename Documentation/devicetree/bindings/{misc => sram}/sram.txt (100%)
> >>  rename Documentation/devicetree/bindings/{soc/sunxi/sram.txt => sram/sunxi-sram.txt} (100%)
> > 
> > I'm not sure about that one. The SRAM bindins we have for sunxi is for
> > an SRAM controller, that maps the SRAM either to the CPU or to the
> > devices.
> > 
> > It's not really related to the other users, and wouldn't it be
> > confusing to have a driver in drivers/soc, and a Documentation in
> > another sub-directory?
> 
> I guess the only relation to other users is the "mmio-sram". In the same
> time this is still similar to e.g. Samsung's sram bindings (where the
> memory is mapped to CPU only).
> 
> Being located in drivers/soc is not an issue here - code for other
> vendors may be moved there as well in the future.
> 
> Of course I do not insist. Actually Rob's comment was only about moving
> sram.txt and Samsung's sram to common place.
> 
> Anyway I will be sending v3 of these because while looking more
> carefully I found hard-coded paths to bindings/misc/sram.txt. I'll fix
> it in next version.

I didn't really have the context. If Rob feels like we should do that,
then go ahead.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH v2 1/3] dt-bindings: Consolidate SRAM bindings from all vendors

[Rob Herring]

On Thu, Oct 22, 2015 at 8:34 AM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> On Thu, Oct 22, 2015 at 06:19:31PM +0900, Krzysztof Kozlowski wrote:
>> On 22.10.2015 18:05, Maxime Ripard wrote:
>> > Hi,
>> >
>> > On Thu, Oct 22, 2015 at 10:25:28AM +0900, Krzysztof Kozlowski wrote:
>> >> SRAM bindings for various SoCs, using the mmio-sram genalloc
>> >> API, are spread over different places - per SoC vendor. Since all of
>> >> these are quite similar (they depend on mmio-sram) move them to a common
>> >> place.
>> >>
>> >> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> >> Cc: Heiko Stuebner <heiko@sntech.de>
>> >> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
>> >> Cc: Chen-Yu Tsai <wens@csie.org>
>> >> Cc: Kukjin Kim <kgene@kernel.org>
>> >> Suggested-by: Rob Herring <robh+dt@kernel.org>
>> >>
>> >> ---
>> >>
>> >> Changes since v1:
>> >> 1. New patch. Extended suggestion from Rob.
>> >> ---
>> >>  .../bindings/{arm/rockchip/pmu-sram.txt => sram/rockchip-pmu-sram.txt}    | 0
>> >>  .../bindings/{arm/rockchip/smp-sram.txt => sram/rockchip-smp-sram.txt}    | 0
>> >>  .../bindings/{arm/exynos/smp-sysram.txt => sram/samsung-sram.txt}         | 0
>> >>  Documentation/devicetree/bindings/{misc => sram}/sram.txt                 | 0
>> >>  .../devicetree/bindings/{soc/sunxi/sram.txt => sram/sunxi-sram.txt}       | 0
>> >>  5 files changed, 0 insertions(+), 0 deletions(-)
>> >>  rename Documentation/devicetree/bindings/{arm/rockchip/pmu-sram.txt => sram/rockchip-pmu-sram.txt} (100%)
>> >>  rename Documentation/devicetree/bindings/{arm/rockchip/smp-sram.txt => sram/rockchip-smp-sram.txt} (100%)
>> >>  rename Documentation/devicetree/bindings/{arm/exynos/smp-sysram.txt => sram/samsung-sram.txt} (100%)
>> >>  rename Documentation/devicetree/bindings/{misc => sram}/sram.txt (100%)
>> >>  rename Documentation/devicetree/bindings/{soc/sunxi/sram.txt => sram/sunxi-sram.txt} (100%)
>> >
>> > I'm not sure about that one. The SRAM bindins we have for sunxi is for
>> > an SRAM controller, that maps the SRAM either to the CPU or to the
>> > devices.
>> >
>> > It's not really related to the other users, and wouldn't it be
>> > confusing to have a driver in drivers/soc, and a Documentation in
>> > another sub-directory?
>>
>> I guess the only relation to other users is the "mmio-sram". In the same
>> time this is still similar to e.g. Samsung's sram bindings (where the
>> memory is mapped to CPU only).
>>
>> Being located in drivers/soc is not an issue here - code for other
>> vendors may be moved there as well in the future.
>>
>> Of course I do not insist. Actually Rob's comment was only about moving
>> sram.txt and Samsung's sram to common place.

I certainly appreciate your finding other instances.

>> Anyway I will be sending v3 of these because while looking more
>> carefully I found hard-coded paths to bindings/misc/sram.txt. I'll fix
>> it in next version.
>
> I didn't really have the context. If Rob feels like we should do that,
> then go ahead.

I'm trying to group by binding type rather than arch or vendor for
common bindings. I think bindings/sram is fine to host both ctrlr and
memory range bindings.

Rob