From: Brian Norris <computersforpeace@gmail.com>
To: Jaedon Shin <jaedon.shin@gmail.com>
Cc: Tejun Heo <tj@kernel.org>, Kishon Vijay Abraham I <kishon@ti.com>,
Ralf Baechle <ralf@linux-mips.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-ide@vger.kernel.org, linux-mips@linux-mips.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 05/10] phy: phy_brcmstb_sata: remove unused definitions
Date: Fri, 23 Oct 2015 13:40:13 -0700 [thread overview]
Message-ID: <20151023204013.GO13239@google.com> (raw)
In-Reply-To: <1445564663-66824-6-git-send-email-jaedon.shin@gmail.com>
On Fri, Oct 23, 2015 at 10:44:18AM +0900, Jaedon Shin wrote:
> Remove unused definitions.
The first one is actually a duplicate (oops!), so is that technically
"unused" or just redundant?
Pedantry aside:
Acked-by: Brian Norris <computersforpeace@gmail.com>
> Signed-off-by: Jaedon Shin <jaedon.shin@gmail.com>
> ---
> drivers/phy/phy-brcmstb-sata.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/phy/phy-brcmstb-sata.c b/drivers/phy/phy-brcmstb-sata.c
> index 8a2cb16a1937..0be55dafe9ea 100644
> --- a/drivers/phy/phy-brcmstb-sata.c
> +++ b/drivers/phy/phy-brcmstb-sata.c
> @@ -26,8 +26,6 @@
>
> #define SATA_MDIO_BANK_OFFSET 0x23c
> #define SATA_MDIO_REG_OFFSET(ofs) ((ofs) * 4)
> -#define SATA_MDIO_REG_SPACE_SIZE 0x1000
> -#define SATA_MDIO_REG_LENGTH 0x1f00
>
> #define MAX_PORTS 2
>
> --
> 2.6.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ide" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-10-23 20:40 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 1:44 [PATCH 00/10] add support SATA for BMIPS_GENERIC Jaedon Shin
2015-10-23 1:44 ` [PATCH 01/10] ata: ahci_brcmstb: make the driver buildable on BMIPS_GENERIC Jaedon Shin
2015-10-23 4:52 ` Florian Fainelli
2015-10-23 21:26 ` Brian Norris
[not found] ` <1445564663-66824-1-git-send-email-jaedon.shin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-10-23 1:44 ` [PATCH 02/10] ata: ahch_brcmstb: add data for port offset Jaedon Shin
2015-10-23 4:54 ` Florian Fainelli
2015-10-23 21:28 ` Brian Norris
2015-10-23 1:44 ` [PATCH 06/10] phy: phy_brcmstb_sata: add data for phy offset Jaedon Shin
2015-10-23 5:04 ` Florian Fainelli
2015-10-23 21:09 ` Brian Norris
2015-10-23 1:44 ` [PATCH 03/10] ata: ahci_brcmstb: add support 40nm platforms Jaedon Shin
2015-10-23 5:01 ` Florian Fainelli
2015-10-23 21:25 ` Brian Norris
[not found] ` <20151023212558.GS13239-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2015-10-24 4:50 ` Jaedon Shin
2015-10-26 17:47 ` Brian Norris
2015-10-23 1:44 ` [PATCH 04/10] phy: phy_brcmstb_sata: make the driver buildable on BMIPS_GENERIC Jaedon Shin
[not found] ` <1445564663-66824-5-git-send-email-jaedon.shin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-10-23 5:01 ` Florian Fainelli
2015-10-23 14:47 ` Kishon Vijay Abraham I
2015-10-23 21:10 ` Brian Norris
2015-10-23 1:44 ` [PATCH 05/10] phy: phy_brcmstb_sata: remove unused definitions Jaedon Shin
2015-10-23 5:02 ` Florian Fainelli
2015-10-23 20:40 ` Brian Norris [this message]
2015-10-23 1:44 ` [PATCH 07/10] phy: phy_brcmstb_sata: add support 40nm platforms Jaedon Shin
[not found] ` <1445564663-66824-8-git-send-email-jaedon.shin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-10-23 5:06 ` Florian Fainelli
2015-10-23 21:09 ` Brian Norris
2015-10-23 1:44 ` [PATCH 08/10] MIPS: BMIPS: brcmstb: add SATA nodes for bcm7346 Jaedon Shin
2015-10-23 1:44 ` [PATCH 09/10] MIPS: BMIPS: brcmstb: add SATA nodes for bcm7360 Jaedon Shin
2015-10-23 1:44 ` [PATCH 10/10] MIPS: BMIPS: brcmstb: add SATA nodes for bcm7362 Jaedon Shin
2015-10-23 3:58 ` [PATCH 00/10] add support SATA for BMIPS_GENERIC Tejun Heo
2015-10-23 4:51 ` Florian Fainelli
2015-10-23 20:35 ` Brian Norris
[not found] ` <20151023203511.GN13239-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2015-10-23 21:30 ` Kevin Cernekee
2015-10-24 4:51 ` Jaedon Shin
2015-10-24 20:43 ` Florian Fainelli
2015-10-27 10:21 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151023204013.GO13239@google.com \
--to=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jaedon.shin@gmail.com \
--cc=kishon@ti.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).