From: Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Vincent Cuissard <cuissard-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
Cc: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-nfc-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org"
<linux-nfc-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org>
Subject: Re: [linux-nfc] [PATCH v3 9/9] NFC: nfcmrvl: update device tree bindings for Marvell NFC
Date: Sat, 24 Oct 2015 01:00:34 +0200 [thread overview]
Message-ID: <20151023230034.GA23609@zurbaran.home> (raw)
In-Reply-To: <CE8AEFC3-74F2-44B9-B7B6-EBDD1966FB3A-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
Hi Vincent,
On Fri, Oct 23, 2015 at 01:47:56PM +0000, Vincent Cuissard wrote:
> Hi Rob,
>
> > Le 23 oct. 2015 à 15:18, Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> a écrit :
> >
> >> On Fri, Oct 23, 2015 at 7:23 AM, Vincent Cuissard <cuissard@marvell.com> wrote:
> >> Align NFC bindgins to use marvell instead of mrvl.
> >>
> >> Signed-off-by: Vincent Cuissard <cuissard-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
> >> ---
> >> Documentation/devicetree/bindings/net/nfc/nfcmrvl.txt | 12 ++++++------
> >> drivers/nfc/nfcmrvl/i2c.c | 2 +-
> >> drivers/nfc/nfcmrvl/spi.c | 2 +-
> >> drivers/nfc/nfcmrvl/uart.c | 2 +-
> >> 4 files changed, 9 insertions(+), 9 deletions(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/net/nfc/nfcmrvl.txt b/Documentation/devicetree/bindings/net/nfc/nfcmrvl.txt
> >> index 41058fc..0f95924 100644
> >> --- a/Documentation/devicetree/bindings/net/nfc/nfcmrvl.txt
> >> +++ b/Documentation/devicetree/bindings/net/nfc/nfcmrvl.txt
> >> @@ -2,9 +2,9 @@
> >>
> >> Required properties:
> >> - compatible: Should be:
> >> - - "mrvl,nfc-uart" for UART devices
> >> - - "mrvl,nfc-i2c" for I2C devices
> >> - - "mrvl,nfc-spi" for SPI devices
> >> + - "marvell,nfc-uart" for UART devices
> >> + - "marvell,nfc-i2c" for I2C devices
> >> + - "marvell,nfc-spi" for SPI devices
> >
> > There is no point in changing these and doing so breaks backwards compatibility.
>
> There is no break since these 2 drivers are new. In the same patchset I first set mrvl and replace it to marvell since I figured out that this is the name for all other Marvell drivers.
>
I agree the i2c and spi drivers are new, but not the uart one.
That one should be supported in a backward compatible way.
Cheers,
Samuel.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-10-23 23:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 12:22 [PATCH v3 0/9] Marvell NFC drivers for i2c and spi Vincent Cuissard
[not found] ` <1445602986-3254-1-git-send-email-cuissard-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
2015-10-23 12:22 ` [PATCH v3 1/9] NFC: nfcmrvl: remove unneeded version defines Vincent Cuissard
2015-10-23 12:22 ` [PATCH v3 2/9] NFC: NCI: export nci_send_frame and nci_send_cmd function Vincent Cuissard
2015-10-23 12:23 ` [PATCH v3 3/9] NFC: nfcmrvl: add firmware download support Vincent Cuissard
2015-10-23 12:23 ` [PATCH v3 4/9] NFC: nfcmrvl: configure head/tail room values per low level drivers Vincent Cuissard
2015-10-23 12:23 ` [PATCH v3 5/9] NFC: nfcmrvl: add i2c driver Vincent Cuissard
2015-10-23 12:23 ` [PATCH v3 6/9] NFC: NCI: move generic spi driver to a module Vincent Cuissard
2015-10-23 12:23 ` [PATCH v3 7/9] NFC: NCI: allow spi driver to choose transfer clock Vincent Cuissard
2015-10-23 12:23 ` [PATCH v3 8/9] NFC: nfcmrvl: add spi driver Vincent Cuissard
2015-10-23 12:23 ` [PATCH v3 9/9] NFC: nfcmrvl: update device tree bindings for Marvell NFC Vincent Cuissard
[not found] ` <1445602986-3254-10-git-send-email-cuissard-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
2015-10-23 13:17 ` Rob Herring
[not found] ` <CAL_JsqJ7a+MNA8BPseGu_L+3yMr=jK-3YiSo+HZkoqJq2XpWgg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-23 13:47 ` Vincent Cuissard
2015-10-23 21:34 ` Rob Herring
[not found] ` <CE8AEFC3-74F2-44B9-B7B6-EBDD1966FB3A-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
2015-10-23 23:00 ` Samuel Ortiz [this message]
[not found] ` <20151023230034.GA23609-nKCvNrh56OoJmsy6czSMtA@public.gmane.org>
2015-10-24 0:15 ` [linux-nfc] " Vincent Cuissard
[not found] ` <3CAE2505-C17A-4A4F-A222-0F0D814B8491-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
2015-10-24 0:22 ` Samuel Ortiz
[not found] ` <20151024002202.GC23609-nKCvNrh56OoJmsy6czSMtA@public.gmane.org>
2015-10-24 0:23 ` Vincent Cuissard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151023230034.GA23609@zurbaran.home \
--to=sameo-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=cuissard-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nfc-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).