From: Mark Brown <broonie@kernel.org>
To: Heiko Schocher <hs@denx.de>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH v3] regulator, dt: add dt support for tps6502x regulator
Date: Tue, 27 Oct 2015 11:12:50 +0900 [thread overview]
Message-ID: <20151027021250.GR28319@sirena.org.uk> (raw)
In-Reply-To: <1445858717-12707-1-git-send-email-hs@denx.de>
[-- Attachment #1: Type: text/plain, Size: 494 bytes --]
On Mon, Oct 26, 2015 at 12:25:17PM +0100, Heiko Schocher wrote:
> add DT support for the tps6502x regulators.
Please use subject lines matching the style for the subsystem.
> + regulators = of_get_child_by_name(np, "regulators");
> + if (!regulators) {
> + dev_err(dev, "regulator node not found\n");
> + return NULL;
> + }
Please use the generic support for locating the DT information for
regulators using regulators_node and of_match in the regulator_desc
rather than open coding this.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-10-27 2:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 11:25 [PATCH v3] regulator, dt: add dt support for tps6502x regulator Heiko Schocher
2015-10-27 2:12 ` Mark Brown [this message]
2015-10-27 6:23 ` Heiko Schocher
[not found] ` <562F184D.8000907-ynQEQJNshbs@public.gmane.org>
2015-10-27 7:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151027021250.GR28319@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hs@denx.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).