From: Damien Riegel <damien.riegel-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
kernel-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org
Subject: Re: [PATCH 2/4] watchdog: ts4800: add new driver for TS-4800 watchdog
Date: Fri, 30 Oct 2015 10:27:19 -0400 [thread overview]
Message-ID: <20151030142719.GB7403@localhost> (raw)
In-Reply-To: <6804900.txcGkbUFcL@wuerfel>
On Fri, Oct 30, 2015 at 01:53:00PM +0100, Arnd Bergmann wrote:
> On Tuesday 27 October 2015 16:33:39 Damien Riegel wrote:
> > +static void ts4800_write_feed(struct ts4800_wdt *wdt, u16 val)
> > +{
> > + __raw_writew(val, wdt->base + TS4800_WTD_FEED);
> > +}
> > +
> >
>
> Using __raw_writew() is broken when you run a big-endian kernel. Better always
> use the normal writew() in device drivers.
Noted for future work. Anyway, this has changed in v2 and the driver now
uses regmap_write instead of __raw_writew, so the endianess issue should
already be taken care of.
Damien
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-10-30 14:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 20:33 [PATCH 0/4] Add board support for TS-4800 Damien Riegel
[not found] ` <1445978021-13961-1-git-send-email-damien.riegel-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org>
2015-10-27 20:33 ` [PATCH 1/4] of: add vendor prefix for Technologic Systems Damien Riegel
[not found] ` <1445978021-13961-2-git-send-email-damien.riegel-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org>
2015-10-30 12:50 ` Arnd Bergmann
2015-10-30 14:17 ` Damien Riegel
2015-10-27 20:33 ` [PATCH 2/4] watchdog: ts4800: add new driver for TS-4800 watchdog Damien Riegel
[not found] ` <1445978021-13961-3-git-send-email-damien.riegel-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org>
2015-10-27 21:20 ` Dinh Nguyen
[not found] ` <CADhT+wdWcYMQ_ZPhcGOye3oP=6N+Yos+sbqV20E5x5Hmfm8ycw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-27 21:51 ` Damien Riegel
2015-10-28 2:05 ` Guenter Roeck
[not found] ` <20151028020501.GA1548-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2015-10-28 16:52 ` Damien Riegel
2015-10-30 12:53 ` Arnd Bergmann
2015-10-30 14:27 ` Damien Riegel [this message]
2015-11-11 23:28 ` Rob Herring
2015-10-27 20:33 ` [PATCH 3/4] ARM: imx_v6_v7_defconfig: add " Damien Riegel
2015-10-27 20:33 ` [PATCH 4/4] ARM: dts: TS-4800: add basic device tree Damien Riegel
[not found] ` <1445978021-13961-5-git-send-email-damien.riegel-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org>
2015-11-11 23:25 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151030142719.GB7403@localhost \
--to=damien.riegel-4ysuxcep3am1wj+d4i0nrvatqe2ktcn/@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kernel-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).