From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v4 4/6] reset: sunxi: Add Allwinner H3 bus resets Date: Wed, 4 Nov 2015 08:30:14 -0800 Message-ID: <20151104163014.GB6114@lukather> References: <1445964626-6484-1-git-send-email-jenskuske@gmail.com> <1445964626-6484-5-git-send-email-jenskuske@gmail.com> <13919923.o3Dj9msmoa@wuerfel> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="abYdCjSRCBwcb+dP" Return-path: Content-Disposition: inline In-Reply-To: <13919923.o3Dj9msmoa@wuerfel> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Arnd Bergmann Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Jens Kuske , Chen-Yu Tsai , Michael Turquette , Linus Walleij , Rob Herring , Philipp Zabel , Emilio =?iso-8859-1?Q?L=F3pez?= , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Vishnu Patekar , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Hans de Goede , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org --abYdCjSRCBwcb+dP Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Hi Arnd, On Fri, Oct 30, 2015 at 09:27:03AM +0100, Arnd Bergmann wrote: > On Tuesday 27 October 2015 17:50:24 Jens Kuske wrote: > > > > +static int sun8i_h3_bus_reset_xlate(struct reset_controller_dev *rcdev, > > + const struct of_phandle_args *reset_spec) > > +{ > > + unsigned int index = reset_spec->args[0]; > > + > > + if (index < 96) > > + return index; > > + else if (index < 128) > > + return index + 32; > > + else if (index < 160) > > + return index + 64; > > + else > > + return -EINVAL; > > +} > > + > > > > This looks like you are doing something wrong and should either > put the actual number into DT, This is the actual number, except that there's some useless registers in between. Allwinner documents it like that: 0x0 Reset 0 0x4 Reset 1 0xc Reset 2 So we have to adjust the offset to account with the blank register in between (0x8). > or use a two-cell representation, with the first cell indicating the > block (0, 1 or 2), and the second cell the index. And the missing register is not a block either. That would also imply either changing the bindings of that driver (and all the current DTS that are using it), or introducing a whole new driver just to deal with some extraordinary offset calculation. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --abYdCjSRCBwcb+dP--