public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Viresh Kumar <viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Rafael Wysocki <rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org>,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org,
	linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	pawel.moll-5wv7dgnIgG8@public.gmane.org,
	ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
	galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	nm-l0cyMroinI0@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
	m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
	open list <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"Rafael J. Wysocki"
	<rafael.j.wysocki-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH V2 3/5] PM / OPP: Remove 'operating-points-names' binding
Date: Wed, 4 Nov 2015 21:09:33 -0600	[thread overview]
Message-ID: <20151105030933.GA26677@rob-hp-laptop> (raw)
In-Reply-To: <c4070eeceb0fdf6a6ab56fcaef1769d01dd01c7e.1446687367.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

On Thu, Nov 05, 2015 at 07:11:54AM +0530, Viresh Kumar wrote:
> These aren't used until now by any DT files and wouldn't be used now as
> we have a better scheme in place now, i.e. opp-property-<name>
> properties.
> 
> Remove the (useless) binding without breaking ABI.
> 
> Reviewed-by: Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
> Signed-off-by: Viresh Kumar <viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

> ---
>  Documentation/devicetree/bindings/opp/opp.txt | 62 +--------------------------
>  1 file changed, 2 insertions(+), 60 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt
> index 61c6f25cf8e2..30c4bb3718bc 100644
> --- a/Documentation/devicetree/bindings/opp/opp.txt
> +++ b/Documentation/devicetree/bindings/opp/opp.txt
> @@ -45,21 +45,10 @@ Devices supporting OPPs must set their "operating-points-v2" property with
>  phandle to a OPP table in their DT node. The OPP core will use this phandle to
>  find the operating points for the device.
>  
> -Devices may want to choose OPP tables at runtime and so can provide a list of
> -phandles here. But only *one* of them should be chosen at runtime. This must be
> -accompanied by a corresponding "operating-points-names" property, to uniquely
> -identify the OPP tables.
> -
>  If required, this can be extended for SoC vendor specfic bindings. Such bindings
>  should be documented as Documentation/devicetree/bindings/power/<vendor>-opp.txt
>  and should have a compatible description like: "operating-points-v2-<vendor>".
>  
> -Optional properties:
> -- operating-points-names: Names of OPP tables (required if multiple OPP
> -  tables are present), to uniquely identify them. The same list must be present
> -  for all the CPUs which are sharing clock/voltage rails and hence the OPP
> -  tables.
> -
>  * OPP Table Node
>  
>  This describes the OPPs belonging to a device. This node can have following
> @@ -454,54 +443,7 @@ Example 4: Handling multiple regulators
>  	};
>  };
>  
> -Example 5: Multiple OPP tables
> -
> -/ {
> -	cpus {
> -		cpu@0 {
> -			compatible = "arm,cortex-a7";
> -			...
> -
> -			cpu-supply = <&cpu_supply>
> -			operating-points-v2 = <&cpu0_opp_table_slow>, <&cpu0_opp_table_fast>;
> -			operating-points-names = "slow", "fast";
> -		};
> -	};
> -
> -	cpu0_opp_table_slow: opp_table_slow {
> -		compatible = "operating-points-v2";
> -		status = "okay";
> -		opp-shared;
> -
> -		opp00 {
> -			opp-hz = /bits/ 64 <600000000>;
> -			...
> -		};
> -
> -		opp01 {
> -			opp-hz = /bits/ 64 <800000000>;
> -			...
> -		};
> -	};
> -
> -	cpu0_opp_table_fast: opp_table_fast {
> -		compatible = "operating-points-v2";
> -		status = "okay";
> -		opp-shared;
> -
> -		opp10 {
> -			opp-hz = /bits/ 64 <1000000000>;
> -			...
> -		};
> -
> -		opp11 {
> -			opp-hz = /bits/ 64 <1100000000>;
> -			...
> -		};
> -	};
> -};
> -
> -Example 6: opp-supported-hw
> +Example 5: opp-supported-hw
>  (example: three level hierarchy of versions: cuts, substrate and process)
>  
>  / {
> @@ -546,7 +488,7 @@ Example 6: opp-supported-hw
>  	};
>  };
>  
> -Example 7: opp-microvolt-<name>, opp-microamp-<name>, turbo-mode-<name>,
> +Example 6: opp-microvolt-<name>, opp-microamp-<name>, turbo-mode-<name>,
>  opp-suspend-<name>:
>  (example: device with two possible microvolt ranges: slow and fast)
>  
> -- 
> 2.6.2.198.g614a2ac
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-11-05  3:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-05  1:41 [PATCH V2 0/5] PM / OPP: opp-supported-hw and <prop>-name bindings Viresh Kumar
2015-11-05  1:41 ` [PATCH V2 1/5] PM / OPP: Add "opp-supported-hw" binding Viresh Kumar
2015-11-05  2:57   ` Rob Herring
2015-11-05  1:41 ` [PATCH V2 2/5] PM / OPP: Add {opp-microvolt|opp-microamp|turbo-mode|opp-suspend}-<name> binding Viresh Kumar
2015-11-05  3:02   ` Rob Herring
2015-11-05  3:19     ` Viresh Kumar
2015-11-05 23:33       ` Rob Herring
2015-11-06  1:53         ` Viresh Kumar
2015-11-10 14:55           ` Viresh Kumar
2015-11-10 15:37             ` Rob Herring
2015-11-05  1:41 ` [PATCH V2 3/5] PM / OPP: Remove 'operating-points-names' binding Viresh Kumar
     [not found]   ` <c4070eeceb0fdf6a6ab56fcaef1769d01dd01c7e.1446687367.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-11-05  3:09     ` Rob Herring [this message]
2015-11-05  1:41 ` [PATCH V2 4/5] PM / OPP: Rename OPP nodes as opp@<opp-hz> Viresh Kumar
2015-11-05  3:18   ` Rob Herring
2015-11-05  1:41 ` [PATCH V2 5/5] ARM: dts: exynos4412: " Viresh Kumar
2015-11-05  1:51   ` Krzysztof Kozlowski
2015-11-05  1:57     ` Viresh Kumar
2015-11-05 22:31 ` [PATCH V2 0/5] PM / OPP: opp-supported-hw and <prop>-name bindings Rafael J. Wysocki
2015-11-06  1:45   ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151105030933.GA26677@rob-hp-laptop \
    --to=robh-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
    --cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=nm-l0cyMroinI0@public.gmane.org \
    --cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
    --cc=rafael.j.wysocki-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox