From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 2/7] doc:bindings:Document for mtcmos regulator on hi6220 SoC Date: Thu, 5 Nov 2015 14:31:33 -0600 Message-ID: <20151105203133.GA9152@rob-hp-laptop> References: <1446730488-31930-1-git-send-email-puck.chen@hisilicon.com> <1446730488-31930-3-git-send-email-puck.chen@hisilicon.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1446730488-31930-3-git-send-email-puck.chen-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Chen Feng Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org, dan.zhao-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, w.f-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, linuxarm-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, haojian.zhuang-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, xuwei5-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, z.liuxinliang-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, kong.kongxinwei-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, qijiwen-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, haojian.zhuang-1ViLX0X+lBJBDgjK7y7TUQ@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, weidong2-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, leo.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, yudongbin-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, peter.panshilin-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, saberlily.xia-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org List-Id: devicetree@vger.kernel.org On Thu, Nov 05, 2015 at 09:34:43PM +0800, Chen Feng wrote: > Add Document for mtcmos driver on hi6220 SoC > > Signed-off-by: Chen Feng > Signed-off-by: Fei Wang > --- > .../bindings/regulator/hisilicon,hi6220-mtcmos.txt | 32 ++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/regulator/hisilicon,hi6220-mtcmos.txt > > diff --git a/Documentation/devicetree/bindings/regulator/hisilicon,hi6220-mtcmos.txt b/Documentation/devicetree/bindings/regulator/hisilicon,hi6220-mtcmos.txt > new file mode 100644 > index 0000000..bb06e1b > --- /dev/null > +++ b/Documentation/devicetree/bindings/regulator/hisilicon,hi6220-mtcmos.txt > @@ -0,0 +1,32 @@ > +Hi6220 mtcmos Voltage regulators > + > +Required parent device properties: > +- compatible: Must be "hisilicon,hi6220-mtcmos-driver" What does "driver" refer to? > +- hisilicon,mtcmos-steady-us: The time to wait for power steady Wouldn't regulator-enable-ramp-delay be equivalent? > +- hisilicon,mtcmos-sc-on-base: address of mtcmos on hi6220 SoC > + > +Required child device properties: > +- regulator-name: The name of mtcmos > +- hisilicon,ctrl-regs: Offset of ctrl-regs > +- hisilicon,ctrl-data: The bit to ctrl the regulator > + > +Example: > + mtcmos { > + compatible = "hisilicon,hi6220-mtcmos-driver"; > + hisilicon,mtcmos-steady-us = <10>; > + hisilicon,mtcmos-sc-on-base = <0xf7800000>; > + hisilicon,mtcmos-acpu-on-base = <0xf65a0000>; > + > + mtcmos1: regulator@a1{ > + regulator-name = "G3D_PD_VDD"; > + regulator-compatible = "mtcmos1"; regulator-compatible is deprecated. Please drop. > + hisilicon,ctrl-regs = <0x830 0x834 0x83c>; > + hisilicon,ctrl-data = <1 0x1>; > + }; > + mtcmos2: regulator@a2{ > + regulator-name = "SOC_MED"; > + regulator-compatible = "mtcmos2"; > + hisilicon,ctrl-regs = <0x830 0x834 0x83c>; > + hisilicon,ctrl-data = <2 0x1>; > + }; > + }; > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html