Re: [PATCH 01/19] clk: sunxi: Add display clock

Maxime Ripard
2015-11-19T15:42:58Z

[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]

On Thu, Nov 12, 2015 at 12:31:54PM -0800, Stephen Boyd wrote:
> On 11/06, Maxime Ripard wrote:
> > Hi Stephen,
> >
> > Thanks for your feedback!
> >
> > On Fri, Oct 30, 2015 at 02:29:02PM -0700, Stephen Boyd wrote:
> > > > +
> > > > + mux = kzalloc(sizeof(*mux), GFP_KERNEL);
> > > > + if (!mux)
> > > [..]
> > > > + goto free_reset;
> > > > + }
> > > > +
> > > > + return;
> > > > +
> > > > +free_reset:
> > > > + kfree(reset_data);
> > > > +free_clk:
> > > > + clk_unregister(clk);
> > >
> > > We really ought to have a clk_composite_unregister() API.
> >
> > Can we?
> >
> > We can always unregister the clock itself, but do we have a way to
> > retrieve the structure that has been allocated in there?
> >
> > (note that it also applies to the generic clocks registration: muxes,
> > dividers, and so on).
>
> Yes we have a way. We've done the same sort of design for other
> generic clocks. Do the __clk_get_hw() thing like in clk-divider.c

Ack. I'll cook up a patch for this then.

Thanks!
Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering