Re: [PATCH 03/19] clk: sunxi: Add TCON channel0 clock

Maxime Ripard
2015-11-06T22:11:22Z

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

Hi,

On Sat, Oct 31, 2015 at 06:19:59PM +0800, Chen-Yu Tsai wrote:
> > +#define SUN4I_A10_TCON_CH0_RESET_SHIFT 29
>
> This is sun5i specific.
>
> A10s manual says bit 30 is the LCD reset, while bit 29 is the TV
> encoder reset. A13/R8 don't mention TCON_CH0 clock. A10/A20 have no
> separate TV encoder reset.
>
> Please rename the clock.

This thing with the A10s is odd, the channel 0 is only used for the
LCD interface, and not the tv encoder (and both the A13 and R8 do have
a TCON).

But you're right, I've fixed it.

Thanks!
Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]