From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 07/19] drm/panel: simple: Add timings for the Olimex LCD-OLinuXino-4.3TS Date: Fri, 6 Nov 2015 16:44:36 -0800 Message-ID: <20151107004436.GS6114@lukather> References: <1446214865-3972-1-git-send-email-maxime.ripard@free-electrons.com> <1446214865-3972-8-git-send-email-maxime.ripard@free-electrons.com> <20151030173230.GC17183@ulmo.nvidia.com> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="u2qWrZzts+9rBanj" Return-path: Content-Disposition: inline In-Reply-To: <20151030173230.GC17183-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Thierry Reding Cc: Mike Turquette , Stephen Boyd , David Airlie , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Laurent Pinchart , Chen-Yu Tsai , Hans de Goede , Alexander Kaplan , Wynter Woods , Boris Brezillon , Thomas Petazzoni , Rob Clark , Daniel Vetter List-Id: devicetree@vger.kernel.org --u2qWrZzts+9rBanj Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Hi Thierry, On Fri, Oct 30, 2015 at 06:32:30PM +0100, Thierry Reding wrote: > On Fri, Oct 30, 2015 at 03:20:53PM +0100, Maxime Ripard wrote: > > Add support for the Olimex LCD-OLinuXino-4.3TS panel to the DRM simple > > panel driver. > > > > It is a 480x272 panel connected through a 24-bits RGB interface. > > > > Signed-off-by: Maxime Ripard > > --- > > drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++ > > 1 file changed, 26 insertions(+) > > I don't see a patch adding the DT binding documentation for this panel. > > Also, the olimex vendor prefix isn't defined. > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > > index f97b73ec4713..3a9ecb64d1e6 100644 > > --- a/drivers/gpu/drm/panel/panel-simple.c > > +++ b/drivers/gpu/drm/panel/panel-simple.c > > @@ -1096,6 +1096,29 @@ static const struct panel_desc shelly_sca07010_bfn_lnn = { > > .bus_format = MEDIA_BUS_FMT_RGB666_1X18, > > }; > > > > +static const struct drm_display_mode olimex_lcd_olinuxino_43ts_mode = { > > + .clock = 9000, > > + .hdisplay = 480, > > + .hsync_start = 480 + 5, > > + .hsync_end = 480 + 5 + 30, > > + .htotal = 480 + 5 + 30 + 10, > > + .vdisplay = 272, > > + .vsync_start = 272 + 8, > > + .vsync_end = 272 + 8 + 5, > > + .vtotal = 272 + 8 + 5 + 3, > > + .vrefresh = 60, > > +}; > > + > > +static const struct panel_desc olimex_lcd_olinuxino_43ts = { > > + .modes = &olimex_lcd_olinuxino_43ts_mode, > > + .num_modes = 1, > > + .size = { > > + .width = 105, > > + .height = 67, > > + }, > > + .bus_format = MEDIA_BUS_FMT_RGB666_1X18, > > +}; > > + > > These mode and panel descriptors are all sorted alphabetically (by > vendor, by model), please keep it so. > > > static const struct of_device_id platform_of_match[] = { > > { > > .compatible = "ampire,am800480r3tmqwa1h", > > @@ -1191,6 +1214,9 @@ static const struct of_device_id platform_of_match[] = { > > .compatible = "shelly,sca07010-bfn-lnn", > > .data = &shelly_sca07010_bfn_lnn, > > }, { > > + .compatible = "olimex,lcd-olinuxino-43-ts", > > + .data = &olimex_lcd_olinuxino_43ts, > > + }, { > > /* sentinel */ > > } > > Here as well. Thanks for your feedback, consider it fixed. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --u2qWrZzts+9rBanj--