From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Brian Norris <computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Javier Martinez Canillas"
<javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>,
"Rafał Miłecki" <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 3/3] doc: dt: mtd: stop referring to driver code for spi-nor IDs
Date: Mon, 16 Nov 2015 17:16:50 -0600 [thread overview]
Message-ID: <20151116231650.GA32557@rob-hp-laptop> (raw)
In-Reply-To: <1447713292-91525-4-git-send-email-computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Mon, Nov 16, 2015 at 02:34:52PM -0800, Brian Norris wrote:
> Pull the supported chip names from drivers/mtd/devices/m25p80.c and stop
> pointing readers to Linux code.
>
> Also (although I see this habit repeated throughout the
> Documentation/devicetree/bindings/ tree), stop using the title "driver"
> in this file, when we're trying explicitly to describe hardware, not
> software.
>
> Signed-off-by: Brian Norris <computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Cc: <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Thanks for the clean-up.
Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> ---
> .../devicetree/bindings/mtd/jedec,spi-nor.txt | 56 ++++++++++++++++++++--
> 1 file changed, 51 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt
> index 2bee68103b01..2c91c03e7eb0 100644
> --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt
> +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt
> @@ -1,15 +1,61 @@
> -* MTD SPI driver for ST M25Pxx (and similar) serial flash chips
> +* SPI NOR flash: ST M25Pxx (and similar) serial flash chips
>
> Required properties:
> - #address-cells, #size-cells : Must be present if the device has sub-nodes
> representing partitions.
> - compatible : May include a device-specific string consisting of the
> - manufacturer and name of the chip. Bear in mind the DT binding
> - is not Linux-only, but in case of Linux, see the "m25p_ids"
> - table in drivers/mtd/devices/m25p80.c for the list of supported
> - chips.
> + manufacturer and name of the chip. A list of supported chip
> + names follows.
> Must also include "jedec,spi-nor" for any SPI NOR flash that can
> be identified by the JEDEC READ ID opcode (0x9F).
> +
> + Supported chip names:
> + at25df321a
> + at25df641
> + at26df081a
> + mr25h256
> + mx25l4005a
> + mx25l1606e
> + mx25l6405d
> + mx25l12805d
> + mx25l25635e
> + n25q064
> + n25q128a11
> + n25q128a13
> + n25q512a
> + s25fl256s1
> + s25fl512s
> + s25sl12801
> + s25fl008k
> + s25fl064k
> + sst25vf040b
> + m25p40
> + m25p80
> + m25p16
> + m25p32
> + m25p64
> + m25p128
> + w25x80
> + w25x32
> + w25q32
> + w25q32dw
> + w25q80bl
> + w25q128
> + w25q256
> +
> + The following chip names have been used historically to
> + designate quirky versions of flash chips that do not support the
> + JEDEC READ ID opcode (0x9F):
> + m25p05-nonjedec
> + m25p10-nonjedec
> + m25p20-nonjedec
> + m25p40-nonjedec
> + m25p80-nonjedec
> + m25p16-nonjedec
> + m25p32-nonjedec
> + m25p64-nonjedec
> + m25p128-nonjedec
> +
> - reg : Chip-Select number
> - spi-max-frequency : Maximum frequency of the SPI bus the chip can operate at
>
> --
> 2.6.0.rc2.230.g3dd15c0
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-11-16 23:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 22:34 [PATCH 0/3] mtd: m25p80: fix some module and documentation issues Brian Norris
[not found] ` <1447713292-91525-1-git-send-email-computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-11-16 22:34 ` [PATCH 3/3] doc: dt: mtd: stop referring to driver code for spi-nor IDs Brian Norris
[not found] ` <1447713292-91525-4-git-send-email-computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-11-16 23:16 ` Rob Herring [this message]
2015-11-17 14:04 ` Javier Martinez Canillas
[not found] ` <564B3407.2020403-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2015-11-18 19:43 ` Brian Norris
[not found] ` <20151118194340.GF140057-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2015-11-18 20:23 ` Javier Martinez Canillas
2015-11-20 0:48 ` [PATCH 0/3] mtd: m25p80: fix some module and documentation issues Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151116231650.GA32557@rob-hp-laptop \
--to=robh-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox