Re: [PATCH 4/7] misc: eeprom: 93xx46: Add DT binding for Atmel AT93C46D devices.

[Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

On Mon, Nov 16, 2015 at 11:16:33PM -0500, Cory Tusar wrote:
> This commit adds a compatible string to the eeprom_93xx46 devicetree
> bindings in support of Atmel AT93C46D devices.
> 
> Signed-off-by: Cory Tusar <cory.tusar-J6Z/VSE8EyIAspv4Qr0y0gC/G2K4zDHf@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/misc/eeprom-93xx46.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt b/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt
> index ba493a8..34a0cc2 100644
> --- a/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt
> +++ b/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt
> @@ -1,7 +1,7 @@
>  EEPROMs (SPI) compatible with Microchip Technology 93xx46 family.
>  
>  Required properties:
> -- compatible : "eeprom-93xx46"
> +- compatible : "eeprom-93xx46", "atmel,at93c46d"

This needs to be clear that it should be the opposite order. Something 
like this:

compatible: One of the following:
	"atmel,at93c46d"
	Followed by "eeprom-93xx46"

>  - data-size : number of data bits per word (either 8 or 16)
>  
>  Optional properties:
> -- 
> 2.4.10
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html