Re: [PATCH 02/10] dt-bindings: nxp: add description of wakeup controller on LPC32xx

[Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

On Fri, Nov 20, 2015 at 03:28:37AM +0200, Vladimir Zapolskiy wrote:
> NXP LPC32xx has three wakeup controllers of two types, this
> descriptions defines DT bindings of wakeup controllers connected to
> MIC, SIC1 and SIC2 interrupt controllers.
> 
> Signed-off-by: Vladimir Zapolskiy <vz-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org>
> ---
>  .../bindings/arm/nxp/nxp,lpc3220-wakeup.txt        | 41 ++++++++++++++++++++++
>  1 file changed, 41 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/arm/nxp/nxp,lpc3220-wakeup.txt
> 
> diff --git a/Documentation/devicetree/bindings/arm/nxp/nxp,lpc3220-wakeup.txt b/Documentation/devicetree/bindings/arm/nxp/nxp,lpc3220-wakeup.txt
> new file mode 100644
> index 0000000..803728f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/nxp/nxp,lpc3220-wakeup.txt
> @@ -0,0 +1,41 @@
> +NXP LPC32xx Wakeup Controller
> +
> +Required properties:
> +- compatible: should be "nxp,lpc3220-wakeup"
> +- reg:  should contain wakeup controller registers location and length
> +- #wakeup-cells: must be 2, the first cell describes wakeup source on
> +  the controller, the second cell is a hardware interrupt number on IC.

This probably needs to be done differently. For one, we already have a 
common property "wakeup-source" with different meaning.

Marc, Is there an example of using stacked irqdomain and mapping of irq 
numbers to wakeup numbers?

Rob

> +
> +Examples:
> +
> +	/* System Control Block */
> +	scb {
> +		compatible = "simple-bus";
> +		ranges = <0x0 0x040004000 0x00001000>;
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +
> +		wakeup_int: wakeup-controller@20 {
> +			compatible = "nxp,lpc3220-wakeup";
> +			reg = <0x20 0x10>;
> +			#wakeup-cells = <2>;
> +		};
> +
> +		wakeup_pin: wakeup-controller@30 {
> +			compatible = "nxp,lpc3220-wakeup";
> +			reg = <0x30 0x10>;
> +			#wakeup-cells = <2>;
> +		};
> +	};
> +
> +	/* Main Interrupt Controller */
> +	mic: interrupt-controller@40008000 {
> +		compatible = "nxp,lpc3220-mic";
> +		reg = <0x40008000 0x4000>;
> +		interrupt-controller;
> +		interrupt-controller-name = "mic";
> +		#interrupt-cells = <2>;
> +
> +		wakeup-sources = <&wakeup_int 7 29>,
> +				 <&wakeup_int 25 27>;
> +	};
> -- 
> 2.1.4
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html