From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH (v4) 1/2] mtd: brcmnand: Add brcm,bcm63268-nand device tree binding Date: Sun, 22 Nov 2015 16:23:34 -0600 Message-ID: <20151122222334.GA18996@rob-hp-laptop> References: <56506D55.3000907@simon.arlott.org.uk> <20151122215945.GA5930@rob-hp-laptop> <56523E85.905@simon.arlott.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <56523E85.905-qdVf85lJwsCyrPCCpiK2c/XRex20P6io@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Simon Arlott Cc: "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Brian Norris , Linux Kernel Mailing List , David Woodhouse , linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Florian Fainelli , Jonas Gorski List-Id: devicetree@vger.kernel.org On Sun, Nov 22, 2015 at 10:15:33PM +0000, Simon Arlott wrote: > Add device tree binding for NAND on the BCM63268. > > The BCM63268 has a NAND interrupt register with combined status and enable > registers. > > Signed-off-by: Simon Arlott Acked-by: Rob Herring > --- > On 22/11/15 21:59, Rob Herring wrote: > >> + * "brcm,nand-bcm63268" > >> + - compatible: should contain "brcm,nand-bcm", "brcm,nand-bcm63268" > > > > vendor,-device is preferred. > > The existing two bindings use brcm,nand-, but I've changed this one. > > .../devicetree/bindings/mtd/brcm,brcmnand.txt | 33 ++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt > index 4ff7128..2644d6c 100644 > --- a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt > +++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt > @@ -72,6 +72,13 @@ we define additional 'compatible' properties and associated register resources w > and enable registers > - reg-names: (required) "nand-int-base" > > + * "brcm,bcm63268-nand" > + - compatible: should contain "brcm,bcm-nand", "brcm,bcm63268-nand" > + - reg: (required) the 'NAND_INTR_BASE' register range, with combined status > + and enable registers, and boot address registers > + - reg-names: (required) "nand-intr-base" > + - clock: (required) reference to the clock for NAND controller > + > * "brcm,nand-iproc" > - reg: (required) the "IDM" register range, for interrupt enable and APB > bus access endianness configuration, and the "EXT" register range, > @@ -148,3 +155,29 @@ nand@f0442800 { > }; > }; > }; > + > +nand@0x10000200 { > + compatible = "brcm,bcm63168-nand", "brcm,bcm63268-nand", > + "brcm,brcmnand-v4.0", "brcm,brcmnand"; > + reg = <0x10000200 0x180>, > + <0x10000600 0x200>, > + <0x100000b0 0x10>; > + reg-names = "nand", "nand-cache", "nand-intr-base"; > + interrupt-parent = <&periph_intc>; > + interrupts = <50>; > + clocks = <&periph_clk 20>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + nand0: nandcs@0 { > + compatible = "brcm,nandcs"; > + reg = <0>; > + nand-on-flash-bbt; > + nand-ecc-strength = <1>; > + nand-ecc-step-size = <512>; > + > + #address-cells = <0>; > + #size-cells = <0>; > + }; > +}; > -- > 2.1.4 > > -- > Simon Arlott > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html