devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dmaengine: usb-dmac: Document SoC specific bindings
@ 2015-11-24  2:20 Simon Horman
  2015-11-24  5:49 ` Yoshihiro Shimoda
  2015-11-24 20:16 ` Rob Herring
  0 siblings, 2 replies; 8+ messages in thread
From: Simon Horman @ 2015-11-24  2:20 UTC (permalink / raw)
  To: Vinod Koul
  Cc: dmaengine-u79uwXL29TY76Z2rM5mHXA, linux-sh-u79uwXL29TY76Z2rM5mHXA,
	Magnus Damm, Simon Horman, devicetree-u79uwXL29TY76Z2rM5mHXA,
	Yoshihiro Shimoda

In general Renesas hardware is not documented to the extent where the
relationship between IP blocks on different SoCs can be assumed although
they may appear to operate the same way. Furthermore the documentation
typically does not specify a version for individual IP blocks. For these
reasons a convention of using the SoC name in place of a version and
providing SoC-specific compat strings has been adopted.

Although not universally liked this convention is used in the bindings for
most drivers for Renesas hardware. The purpose of this patch is to
update the Renesas USB DMA Controller driver to follow this convention.

Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
Signed-off-by: Simon Horman <horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>

---
* r8a7792 (R-Car V2H) is omitted as my reading of the documentation
  is that Renesas USB-DMAC does not exist on that SoC
* r8a7795 (R-Car H2) is omitted as its unclear to me on the compatibility
  of USB-DMAC that SoC

* Once this has been merged I intend to provide follow-up patches
  to use these new compat strings in the relevant dtsi files.
---
 Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt b/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt
index 040f365954cc..3bb624e10615 100644
--- a/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt
+++ b/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt
@@ -1,7 +1,12 @@
 * Renesas USB DMA Controller Device Tree bindings
 
 Required Properties:
-- compatible: must contain "renesas,usb-dmac"
+- compatible: "renesas,usb-dmac-<soctype>", "renesas,usb-dmac" as fallback.
+	      Examples with soctypes are:
+		- "renesas,usb-dmac-r8a7790" (R-Car H2)
+		- "renesas,usb-dmac-r8a7791" (R-Car M2-W)
+		- "renesas,usb-dmac-r8a7793" (R-Car M2-N)
+		- "renesas,usb-dmac-r8a7794" (R-Car E2)
 - reg: base address and length of the registers block for the DMAC
 - interrupts: interrupt specifiers for the DMAC, one for each entry in
   interrupt-names.
@@ -15,7 +20,7 @@ Required Properties:
 Example: R8A7790 (R-Car H2) USB-DMACs
 
 	usb_dmac0: dma-controller@e65a0000 {
-		compatible = "renesas,usb-dmac";
+		compatible = "renesas,usb-dmac-r8a7790", "renesas,usb-dmac";
 		reg = <0 0xe65a0000 0 0x100>;
 		interrupts = <0 109 IRQ_TYPE_LEVEL_HIGH
 			      0 109 IRQ_TYPE_LEVEL_HIGH>;
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2015-12-02  0:54 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-24  2:20 [PATCH] dmaengine: usb-dmac: Document SoC specific bindings Simon Horman
2015-11-24  5:49 ` Yoshihiro Shimoda
     [not found]   ` <SG2PR06MB09198719427CB3F4FE532834D8060-ESzmfEwOt/zNQ8RBPPB5A20DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2015-11-25  0:21     ` Simon Horman
2015-11-24 20:16 ` Rob Herring
2015-11-25  0:20   ` Simon Horman
2015-12-01  6:47     ` Simon Horman
2015-12-01  8:33       ` Geert Uytterhoeven
2015-12-02  0:54         ` Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).