Re: [PATCH (v5) 3/11] MIPS: bmips: Add bcm6345-l2-timer interrupt controller

Guenter Roeck
2016-05-09T13:06:05Z

On 05/09/2016 05:01 AM, Álvaro Fernández Rojas wrote:
> Hello Guenter,
>
> Are there any other issues preventing this patches from being merged?
>

My major problem/concern is the interrupt handling and the repeated
restart of the hardware timer with continuously reduced timeouts.
This appears fragile, and it doesn't really make sense from a system
level point of view. Unfortunately, I don't have a data sheet for
the chip, nor the means or the time to test it myself. So we are pretty
much in limbo, unless someone from Broadcom confirms that, yes, this is
the one and expected means to program this watchdog.

Guenter

> Regards,
> Álvaro.
> _____________________________
> From: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org <mailto:linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>>
> Sent: martes, diciembre 1, 2015 1:23 a. m.
> Subject: Re: [PATCH (v5) 3/11] MIPS: bmips: Add bcm6345-l2-timer interrupt controller
> To: Simon Arlott <simon-A6De1vDTPLDsq35pWSNszA@public.gmane.org <mailto:simon-A6De1vDTPLDsq35pWSNszA@public.gmane.org>>, Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org <mailto:tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>>
> Cc: Ralf Baechle <ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org <mailto:ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>>, Linux Kernel Mailing List <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <mailto:linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>>, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org <mailto:mark.rutland-5wv7dgnIgG8@public.gmane.org>>, Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org <mailto:f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>>, Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org <mailto:ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>>, Kevin Cernekee <cernekee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org <mailto:cernekee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>>, MIPS Mailing List <linux-mips@linux-mips.org <mailto:linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>>, Kumar Gala <galak-sgV2jX0FEOJiIJoWrK/4GQ@public.gmane.orgg <mailto:galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>>, Miguel Gaio <miguel.gaio-HH44TBFINEIAvxtiuMwx3w@public.gmane.org <mailto:miguel.gaio-HH44TBFINEIAvxtiuMwx3w@public.gmane.org>>, Jonas Gorski <jogo-p3rKhJxN3npAfugRpC6u6w@public.gmane.org <mailto:jogo-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>>, Marc Zyngier <marc.zyngier-5wv7dgnIgG8@public.gmane.org <mailto:marc.zyngier-5wv7dgnIgG8@public.gmane.org>>, Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org <mailto:pawel.moll-AbSShOkvfpQ@public.gmane.orgm>>, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org <mailto:robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>>, <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <mailto:devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>>, Maxime
> Bizon <mbizon-MmRyKUhfbQ9GWvitb5QawA@public.gmane.org <mailto:mbizon-MmRyKUhfbQ9GWvitb5QawA@public.gmane.org>>, Wim Van Sebroeck <wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org <mailto:wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org>>, <linux-watchdog-u79uwXL29TbrhsbdSgBK9A@public.gmane.orgrg <mailto:linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>>, Jason Cooper <jason@lakedaemon.net <mailto:jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>>
>
>
> On 11/28/2015 04:26 AM, Simon Arlott wrote:
> > Add the BCM6345/BCM6318 timer as an interrupt controller so that it can be
> > used by the watchdog to warn that its timer will expire soon.
> >
> > Support for clocksource/clockevents is not implemented as the timer
> > interrupt is not per CPU (except on the BCM6318) and the MIPS clock is
> > better. This could be added later if required without changing the device
> > tree binding.
> >
> > Signed-off-by: Simon Arlott <simon-A6De1vDTPLDsq35pWSNszA@public.gmane.org <mailto:simon@fire.lp0.eu>>
>
> Hi Simon,
>
> can you please re-send the entire series, with all Acked-by:/Reviewed-by:
> tags as appropriate ?
>
> Thanks,
> Guenter
>
>
>
>

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in