Re: [PATCH 3/4] watchdog: Add brcm,bcm6345-wdt device tree binding

Rob Herring
2015-11-22T22:13:52Z

On Sat, Nov 21, 2015 at 07:04:39PM +0000, Simon Arlott wrote:
> Add device tree binding for the BCM6345 watchdog.
>
> This uses the BCM6345 timer for its warning interrupt.
>
> Signed-off-by: Simon Arlott <simon-A6De1vDTPLDsq35pWSNszA@public.gmane.org>

Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

> ---
> .../bindings/watchdog/brcm,bcm6345-wdt.txt | 35 ++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/watchdog/brcm,bcm6345-wdt.txt
>
> diff --git a/Documentation/devicetree/bindings/watchdog/brcm,bcm6345-wdt.txt b/Documentation/devicetree/bindings/watchdog/brcm,bcm6345-wdt.txt
> new file mode 100644
> index 0000000..9d852d4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/brcm,bcm6345-wdt.txt
> @@ -0,0 +1,35 @@
> +BCM6345 Watchdog timer
> +
> +Required properties:
> +
> +- compatible: should be "brcm,bcm63<soc>-wdt", "brcm,bcm6345-wdt"
> +- reg: Specifies base physical address and size of the registers.
> +- clocks: Specify the clock used for timing
> +
> +Optional properties:
> +
> +- interrupt-parent: phandle to the interrupt controller
> +- interrupts: Specify the interrupt used for the watchdog timout warning
> +- timeout-sec: Contains the default watchdog timeout in seconds
> +
> +Example:
> +
> +watchdog {
> + compatible = "brcm,bcm63168-wdt", "brcm,bcm6345-wdt";
> + reg = <0x1000009c 0x0c>;
> + clocks = <&periph_clk>;
> +
> + interrupt-parent = <&timer>;
> + interrupts = <3>;
> + timeout-sec = <30>;
> +};
> +
> +watchdog {
> + compatible = "brcm,bcm6318-wdt", "brcm,bcm6345-wdt";
> + reg = <0x10000068 0x0c>;
> + clocks = <&periph_clk>;
> +
> + interrupt-parent = <&timer>;
> + interrupts = <3>;
> + timeout-sec = <30>;
> +};
> --
> 2.1.4
>
> --
> Simon Arlott